Skip to content

Add logic to check CR in progress for trivial review #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-bruten-mo merged 3 commits into from
Jan 23, 2026
Merged

Add logic to check CR in progress for trivial review #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fbb875
add logic to check CR in progress for trivial review
jennyhickson Jan 23, 2026
a2228fb
yamllint
jennyhickson Jan 23, 2026
1c3e1d3
Update .github/workflows/track-review-project.yaml
jennyhickson Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/track-review-project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,13 @@ jobs:
sr_approved=$(echo "$reviews" | jq --arg sr "$scitech_reviewer" '[.reviews[] | select(.author.login == $sr and .state == "APPROVED")] | length')
sr_changes=$(echo "$reviews" | jq --arg sr "$scitech_reviewer" '[.reviews[] | select(.author.login == $sr and (.state == "CHANGES_REQUESTED" or .state == "COMMENTED"))] | length')

cr_approved=$(echo "$reviews" | jq --arg cr "$code_reviewer" '[.reviews[] | select(.author.login == $cr and .state == "APPROVED")] | length')
cr_changes=$(echo "$reviews" | jq --arg cr "$code_reviewer" '[.reviews[] | select(.author.login == $cr and (.state == "CHANGES_REQUESTED" or .state == "COMMENTED"))] | length')

[[ ! -z "$scitech_reviewer" ]] && [[ "$sr_requested" -eq 0 ]] && [[ "$sr_approved" -eq 0 ]] && [[ "$sr_changes" -eq 0 ]] && echo "SR_REQUEST_REQUIRED=true" >> $GITHUB_ENV

if [[ -z "$scitech_reviewer" ]] && [[ "$cr_requested" -gt 0 ]]; then
echo "No SR set and CR requested so assuming this is trivial"
if [[ -z "$scitech_reviewer" ]] && [[ "$cr_requested" -gt 0 || "$cr_approved" -gt 0 || "$cr_changes" -gt 0 ]]; then
echo "No SR set and CR in progress so assuming this is trivial"
else
if [[ "$sr_approved" -eq 0 ]]; then
if [[ -z "$scitech_reviewer" ]] && [[ "$sr_changes" -eq 0 ]]; then
Expand All @@ -127,8 +130,7 @@ jobs:
fi
fi

cr_approved=$(echo "$reviews" | jq --arg cr "$code_reviewer" '[.reviews[] | select(.author.login == $cr and .state == "APPROVED")] | length')
cr_changes=$(echo "$reviews" | jq --arg cr "$code_reviewer" '[.reviews[] | select(.author.login == $cr and (.state == "CHANGES_REQUESTED" or .state == "COMMENTED"))] | length')
# SR complete or trivial PR so move to code review states

if [[ "$cr_approved" -gt 0 ]]; then
required_state="Approved"
Expand Down
Loading