More BL diagnostics for PS49 - #664
Open
iboutle wants to merge 12 commits into
Open
Conversation
iboutle
marked this pull request as ready for review
July 29, 2026 09:33
Output the standard deviation of orography ancillary (UM STASH 6-203) from the orographic drag diagnostics. Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
Adrian Lock (Adrian-Lock)
approved these changes
Aug 24, 2026
Adrian Lock (Adrian-Lock)
left a comment
Contributor
There was a problem hiding this comment.
Looks good. New names for cloud cover diagnostics that includes the cloud octa threshold is a good idea. Approving
Contributor
Author
|
Erica Neininger (@ericaneininger) this is ready for code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Adrian Lock (@Adrian-Lock)
Code Reviewer: Erica Neininger (@ericaneininger)
Diagnostics requested by R2O for downstream uses as part of PS49
We also rename:
for consistency with the new diagnostics
tag3.1_new_bl_diags tagged for use at vn3.1
Some example output of the new diagnostics:





Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - new_bl_diags/run1
Suite Information
Task Information
✅ succeeded tasks - 1213
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review