Skip to content

More BL diagnostics for PS49 - #664

Open
iboutle wants to merge 12 commits into
MetOffice:mainfrom
iboutle:new_bl_diags
Open

More BL diagnostics for PS49#664
iboutle wants to merge 12 commits into
MetOffice:mainfrom
iboutle:new_bl_diags

Conversation

@iboutle

@iboutle iboutle commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer: Adrian Lock (@Adrian-Lock)
Code Reviewer: Erica Neininger (@ericaneininger)

Diagnostics requested by R2O for downstream uses as part of PS49

UM stashcode LFRic id
3-344 surface__t10m_ssi
3-345 surface__q10m_ssi
3-355 turbulence__thermal_speed
3-576 surface__visibility_with_precip_land
3-577 surface__visibility_with_precip_ssi
6-203 orographic_drag__sd_orog
9-208 cloud__cloud_base_0p1_okta
9-212 cloud__cloud_base_4p5_okta
9-215 cloud__cloud_base_7p9_okta

We also rename:

  • cloud__cloud_base_altitude to cloud__cloud_base_2p5_okta
  • cloud__cloud_top_altitude to cloud__cloud_top_2p5_okta
    for consistency with the new diagnostics

tag3.1_new_bl_diags tagged for use at vn3.1

Some example output of the new diagnostics:
Screenshot from 2026-07-29 10-27-48
Screenshot from 2026-07-29 10-27-18
Screenshot from 2026-07-29 10-26-20
Screenshot from 2026-07-29 10-24-51
Screenshot from 2026-07-28 14-43-14

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - new_bl_diags/run1

Suite Information

Item Value
Suite Name new_bl_diags/run1
Suite User ian.boutle
Workflow Start 2026-07-28T13:09:11
Groups Run developer', 'lfric_atm_nwp_gal9_oper-C224_MG_ex1a_cce_production-32bit
Dependency Reference Main Like
casim MetOffice/casim@2026.07.1 True
jules MetOffice/jules@2026.07.1 True
lfric_apps iboutle/lfric_apps@new_bl_diags False
lfric_core MetOffice/lfric_core@2026.07.1 True
moci MetOffice/moci@2026.07.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True
socrates MetOffice/socrates@2026.07.1 True
socrates-spectral MetOffice/socrates-spectral@2026.07.1 True
ukca MetOffice/ukca@2026.07.1 True

Task Information

✅ succeeded tasks - 1213

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@iboutle iboutle self-assigned this Jul 24, 2026
@iboutle iboutle added this to the Autumn 2026 milestone Jul 24, 2026
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Jul 24, 2026
@iboutle iboutle changed the title More OS diagnostics for PS49 More BL diagnostics for PS49 Jul 24, 2026
@iboutle
iboutle marked this pull request as ready for review July 29, 2026 09:33
Comment thread interfaces/jules_interface/source/kernel/jules_imp_kernel_mod.F90 Outdated
iboutle and others added 5 commits August 6, 2026 09:32
Output the standard deviation of orography ancillary (UM STASH 6-203)
from the orographic drag diagnostics.

Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
@github-actions

Copy link
Copy Markdown

⚠️ Hello iboutle!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

@Adrian-Lock Adrian Lock (Adrian-Lock) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. New names for cloud cover diagnostics that includes the cloud octa threshold is a good idea. Approving

@iboutle

iboutle commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Erica Neininger (@ericaneininger) this is ready for code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants