Skip to content

Correct the sample_physics_winds_correction option #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tommbendall wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Correct the sample_physics_winds_correction option #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c86b7a
Migrate changes to fix sample_physics_wind_correction
tommbendall Dec 17, 2025
09193b3
Merge branch 'stable' into TBendall/smp_phys_wind_correct
tommbendall Dec 17, 2025
610b65e
add myself to contributors and option to tests
tommbendall Dec 17, 2025
cffb059
fix config
tommbendall Dec 18, 2025
fc339ea
update dependency
tommbendall Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
| ----------- | --------- | ----------- | ---- |
| james-bruten-mo | James Bruten | Met Office | 2025-12-09 |
| jennyhickson | Jenny Hickson | Met Office | 2025-12-10 |
| tommbendall | Thomas Bendall | Met Office | 2025-12-17 |
4 changes: 2 additions & 2 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ lfric_apps:
ref:

lfric_core:
source: git@github.com:MetOffice/lfric_core.git
ref: 2025.12.1
source: git@github.com:tommbendall/lfric_core.git
ref: TBendall/smp_phys_wind_correct

moci:
source: git@github.com:MetOffice/moci.git
Expand Down
1 change: 1 addition & 0 deletions rose-stem/app/lfric_atm/opt/rose-app-camembert_case3_gj1214b.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ orog_init_option='none'
!!lowest_level='gradient'
!!microphysics_placement='slow'
!!orographic_drag_placement='slow'
sample_physics_winds_correction=.true.
!!spectral_gwd_placement='slow'

[namelist:planet]
Expand Down
1 change: 1 addition & 0 deletions rose-stem/app/lfric_atm/opt/rose-app-hd209458b.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ orog_init_option='none'
!!lowest_level='gradient'
!!microphysics_placement='slow'
!!orographic_drag_placement='slow'
sample_physics_winds_correction=.true.
!!spectral_gwd_placement='slow'

[namelist:planet]
Expand Down
81 changes: 42 additions & 39 deletions science/gungho/source/algorithm/physics/map_fd_to_prognostics_alg_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ contains
use matrix_vector_kernel_mod, only: matrix_vector_kernel_type
use sci_average_w2b_to_w2_kernel_mod, &
only: average_w2b_to_w2_kernel_type
use sci_w3_to_w2_average_kernel_mod, only: w3_to_w2_average_kernel_type
use sci_w3_to_w2_correction_kernel_mod, &
only: w3_to_w2_correction_kernel_type

Expand All @@ -239,13 +238,16 @@ contains
type( field_type ) :: r_u
type( field_type ) :: u_broken
type( field_type ) :: u_lat_w2, u_lon_w2, u_up_w2
type( field_type ) :: u_lat_large, u_lon_large
type( field_type ) :: u_correction
type( field_type ), pointer :: rmultiplicity_w2
type( field_type ), pointer :: displacement
type( field_type ), pointer :: chi(:)
type( field_type ), pointer :: panel_id
type( operator_type ), pointer :: u_lon_map
type( operator_type ), pointer :: u_lat_map
type( operator_type ), pointer :: u_up_map
type( function_space_type ), pointer :: w2_fs
type( function_space_type ), pointer :: w2b_fs

type( mesh_type ), pointer :: mesh
Expand All @@ -254,44 +256,7 @@ contains

mesh => u%get_mesh()

if (sample_physics_winds .and. sample_physics_winds_correction) then

chi => get_coordinates(mesh%get_id())
rmultiplicity_w2 => get_rmultiplicity_fv(W2, mesh%get_id())
panel_id => get_panel_id(mesh%get_id())
call u_lon_w2%initialise( u%get_function_space() )
call u_lat_w2%initialise( u%get_function_space() )
call u_up_w2%initialise( u%get_function_space() )

call invoke( setval_c(u_lon_w2, 0.0_r_def), &
setval_c(u_lat_w2, 0.0_r_def), &
setval_c(u_up_w2, 0.0_r_def), &
w3_to_w2_average_kernel_type(u_lon_w2, u_lon, &
rmultiplicity_w2), &
w3_to_w2_average_kernel_type(u_lat_w2, u_lat, &
rmultiplicity_w2), &
w3_to_w2_average_kernel_type(u_up_w2, u_up, &
rmultiplicity_w2) )

! Apply correction
if (geometry == geometry_spherical .and. topology == topology_fully_periodic) then
displacement => get_w3_to_w2_displacement(mesh%get_id())
! Correct horizontal winds
! Vertical wind not needed for horizontal W2 DoFs, so don't correct
call invoke( w3_to_w2_correction_kernel_type(u_lon_w2, u_lon, 1, &
displacement, &
panel_id, 1), &
w3_to_w2_correction_kernel_type(u_lat_w2, u_lat, 1, &
displacement, &
panel_id, 1) )
end if

! Convert from physical wind components into computational wind
call invoke( convert_phys_to_hdiv_kernel_type(u, u_lon_w2, u_lat_w2, &
u_up_w2, chi, panel_id, &
geometry) )

else if (sample_physics_winds) then
if (sample_physics_winds) then

w2b_fs => function_space_collection%get_fs(mesh, 0, 0, W2broken)
rmultiplicity_w2 => get_rmultiplicity_fv(W2, mesh%get_id())
Expand All @@ -308,6 +273,44 @@ contains
dg_inc_matrix_vector_kernel_type(u_broken, u_up, u_up_map), &
average_w2b_to_w2_kernel_type(u, u_broken, rmultiplicity_w2) )

if (sample_physics_winds_correction &
.and. geometry == geometry_spherical &
.and. topology == topology_fully_periodic) then

w2_fs => u%get_function_space()
call u_lon_w2%initialise( w2_fs )
call u_lat_w2%initialise( w2_fs )
call u_up_w2%initialise( w2_fs )
call u_correction%initialise( w2_fs )
call u_lon_large%initialise( u_lon%get_function_space(), halo_depth=2 )
call u_lat_large%initialise( u_lat%get_function_space(), halo_depth=2 )

displacement => get_w3_to_w2_displacement(mesh%get_id())
chi => get_coordinates(mesh%get_id())
panel_id => get_panel_id(mesh%get_id())

call invoke( setval_c(u_lon_w2, 0.0_r_def), &
setval_c(u_lat_w2, 0.0_r_def), &
setval_c(u_up_w2, 0.0_r_def), &
! Copy u_lon and u_lat to fields with appropriate depth
setval_X(u_lon_large, u_lon), &
setval_X(u_lat_large, u_lat), &
! Correct horizontal wind components (but not vertical)
w3_to_w2_correction_kernel_type(u_lon_w2, u_lon_large, 1, &
displacement, &
panel_id, 1), &
w3_to_w2_correction_kernel_type(u_lat_w2, u_lat_large, 1, &
displacement, &
panel_id, 1), &
! Convert components to HDiv field
convert_phys_to_hdiv_kernel_type(u_correction, &
u_lon_w2, u_lat_w2, &
u_up_w2, chi, panel_id, &
geometry), &
! Increment wind with correction field
inc_X_plus_Y(u, u_correction) )
end if

else

call u%copy_field_properties(r_u)
Expand Down
Loading