-
Notifications
You must be signed in to change notification settings - Fork 115
Radaer api la side - part two initialisation #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alan J Hewitt (alanjhewitt)
wants to merge
45
commits into
MetOffice:main
Choose a base branch
from
alanjhewitt:radaer_api_la_side_5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
453666d
merging changes from older branch
alanjhewitt 3f2eaa9
Add RADAER API documentation
alanjhewitt 1b91106
Add documentation
alanjhewitt f114df3
tidy
alanjhewitt 8281df6
I think I need new namelist in all of these
alanjhewitt 84f4601
Beginning of initialisation pipework to UKCA repo
alanjhewitt 763c39a
Beginning of initialisation pipework to UKCA repo
alanjhewitt d8f4d36
Revert " Add documentation"
alanjhewitt 13cc02d
Revert " Beginning of initialisation pipework to UKCA repo"
alanjhewitt 7501b76
Revert " Beginning of initialisation pipework to UKCA repo"
alanjhewitt f6e3b82
Revert " I think I need new namelist in all of these"
alanjhewitt 2d4b474
Revert " merging changes from older branch"
alanjhewitt 568abf9
messy - but now only one versions.py
alanjhewitt 3ccbb0d
maybe sorted git revert
alanjhewitt 09bd990
only ukca setting should trigger i_mode_setup
alanjhewitt b2541ef
pass dust ageing and BC tuning setting to radaer in namelist
alanjhewitt a132533
dust ageing not allowed for dust only
alanjhewitt 8deee3e
initialisation pipework
alanjhewitt 88c1669
Its time to start testing this change
alanjhewitt 621164b
Fixed errors in upgrade macro
alanjhewitt 6b74a99
Typo
alanjhewitt 2fc181b
Typo
alanjhewitt 0cdd0db
Merge branch 'MetOffice:main' into radaer_api_la_side_5
alanjhewitt 338a1ae
LFRic needs to see these UKCA modules
alanjhewitt c11ade5
tidy - makes it read better in emacs
alanjhewitt bd2ac92
I think this fail-if test is broken
alanjhewitt aa48fcd
Fix build errors
alanjhewitt e49ca5f
some fixes
alanjhewitt 904d47b
build errors
alanjhewitt 8feab8d
validate rose-meta error
alanjhewitt 2c0477a
whoops - forgotten an argument
alanjhewitt 94cb9ec
typo
alanjhewitt 05b4cae
This will now use the enumeration values for mode_setup
alanjhewitt 5d9fc41
Fixing build errors
alanjhewitt f0002bc
Run time errors - integers dont match
alanjhewitt 81ab53c
Only initialise when l_radaer is true
alanjhewitt c6b5b0f
use allocatable lists specific to i_mode_setup
alanjhewitt a83cb0f
include new UKCA module
alanjhewitt 71375a4
l_sustrat is now a namelist option
alanjhewitt 88d1e96
sustrat defaults to true
alanjhewitt fba5745
Mohit and Ian suggested changes
alanjhewitt b2fe4b5
I used git mv to hopefully preserve history
alanjhewitt c5a32d6
Remove trailing white space
alanjhewitt 9c6c53a
build error
alanjhewitt 766fafb
validate rose meta failure
alanjhewitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| .. ----------------------------------------------------------------------------- | ||
| (c) Crown copyright Met Office. All rights reserved. | ||
| The file LICENCE, distributed with this code, contains details of the terms | ||
| under which the code may be used. | ||
| ----------------------------------------------------------------------------- | ||
| .. _radaer_api_index: | ||
|
|
||
| Summary of RADAER | ||
| ================================ | ||
|
|
||
| RADAER is a package of software within the UKCA repository that is called | ||
| independently of the rest of UKCA. Functionally, it sits in slow physics and | ||
| deals with the interactions between aerosols and SOCRATES (radiation) and is | ||
| called prior to the SOCRATES radiation code. | ||
|
|
||
| RADAER gets called directly from its parent applications (for example in | ||
| LFRic_apps via radaer_kernel_mod). | ||
|
|
||
|
|
||
|
|
||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :glob: | ||
|
|
||
| * |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| .. ----------------------------------------------------------------------------- | ||
| (c) Crown copyright Met Office. All rights reserved. | ||
| The file LICENCE, distributed with this code, contains details of the terms | ||
| under which the code may be used. | ||
| ----------------------------------------------------------------------------- | ||
|
|
||
| ========== | ||
| RADAER API | ||
| ========== | ||
|
|
||
| :Author: Alan J Hewitt | ||
|
|
||
| Description of RADAER API | ||
| ========================= | ||
|
|
||
| Radaer will be available to the parent application via a single API module as | ||
| a minimal set of top_level subroutines. These will include an initialisation | ||
| function to correctly set up radaer for the user inputs and a runtime module. | ||
|
|
||
| Names of subroutines presented via the API will start ```ukca_radaer_``` | ||
|
|
||
| All run time communication between the parent model and UKCA will be via | ||
| argument lists. | ||
|
|
||
| All RADAER state variables will be available to the parent model between | ||
| time steps as native FORTRAN arrays, for inspection and possible modification. | ||
| The fields in these arrays will be in a specific order and size, which will | ||
| differ depending on user configuration. The lists of fields will be determined | ||
| by field names retrieved by the parent at run time. | ||
|
|
||
| The RADAER interface was designed to be very lean. No significant further | ||
| developments are intended for radaer. There is scope to revisit the lean | ||
| interface in future, if significant developments are required. However, | ||
| replacing RADAER with a different package is more likely to happen in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing this and just setting mode_setup=SUBCOCSSDU_7mode in the upgrade macro. The value when dust and clim is selected is irrelevant because it's trigger ignored, but doing this makes duonly_2mode the default value in the GUI, and I think 7mode would be the better default to appear when someone switches on ukca.