Fix averaging kernel used in stochastic physics filter

[tommbendall]

PR Summary

Sci/Tech Reviewer: @thomasmelvin
Code Reviewer: @cameronbateman-mo

This fixes the wth_to_w0_average kernel, which was using the incorrect multiplicity to average a field from Wtheta to W0. This kernel is used in a 1-2-1 filter in stochastic physics -- the filter is performed a number of times, and the impact of the incorrect multiplicity is that the stochastic physics tendencies were an order of magnitude too small.

• linked Stochastic Physics Fixes lfric_apps#148

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's
  style guidelines
• Comments have been included that aid understanding and enhance the
  readability of the code
• My changes generate no new warnings

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite
  using this branch
• If any tests fail (rose-stem or CI) the reason is understood and
  acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system
  tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource
  and have been allocated to an appropriate testing group (i.e. the
  developer tests are for jobs which use a small amount of compute resource
  and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - fix_w0_wth_filter/run1

Suite Information

Item	Value
Suite Name	fix_w0_wth_filter/run1
Suite User	thomas.bendall
Workflow Start	2026-01-15T17:31:52
Groups Run	developer

Dependency	Reference	Main Like
lfric_core	tommbendall/lfric_core@TBendall/FixW0WthFilter	False
SimSys_Scripts	MetOffice/[email protected]	True

Task Information

✅ succeeded tasks - 372

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable
  performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance
  of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
  Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
  Simulation Systems AI policy
  (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and
  confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel
  interface, optimisation scripts, LFRic data structure code) then please
  contact the
  [email protected]

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[thomasmelvin]

The changes are correct and will fix the incorrect increments. I was surprised that no KGO's have changed with this fix. do no tests in the developer suite use stochastic physics? do more of the tests need to be run to pick up any other KGO changes?

[tommbendall]

The changes are correct and will fix the incorrect increments. I was surprised that no KGO's have changed with this fix. do no tests in the developer suite use stochastic physics? do more of the tests need to be run to pick up any other KGO changes?

I should've add the KGO label. It does changed KGOs, but I have bundled these into the linked Apps PR which has a handful of other fixes to the stochastic fixes.

[thomasmelvin]

I missed this was a linked ticket, I'm happy with the changes here and will let the scientific impact of them be reviewed in the related lfric_apps pull request

[cameronbateman-mo]

All looks good, moving to approved.