Skip to content

Allow computation and storage of height at W0 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tommbendall wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow computation and storage of height at W0 #229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fece3ae
Allow computation and storage of height at W0
tommbendall Jan 20, 2026
4a147d5
add my name to contributors, also on this PR...
tommbendall Jan 20, 2026
00e04d1
clear new inventories
tommbendall Jan 23, 2026
6d25872
remove myself from contributors
tommbendall Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
| jennyhickson | Jenny Hickson | Met Office | 2025-12-10 |
| mo-marqh | Mark Hedley | Met Office | 2025-12-11 |
| MatthewHambley | Matthew Hambley | Met Office | 2025-12-15 |
| tommbendall | Thomas Bendall | Met Office | 2025-01-20 |
10 changes: 9 additions & 1 deletion components/science/source/algorithm/sci_geometric_constants_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module sci_geometric_constants_mod
use constants_mod, only: i_def, r_def, l_def, str_def
use extrusion_mod, only: TWOD, PRIME_EXTRUSION
use field_mod, only: field_type
use fs_continuity_mod, only: W1, W2, W2H, W3, Wtheta
use fs_continuity_mod, only: W0, W1, W2, W2H, W3, Wtheta
use function_space_collection_mod, only: function_space_collection
use function_space_mod, only: function_space_type
use integer_field_mod, only: integer_field_type
Expand Down Expand Up @@ -77,6 +77,8 @@ module sci_geometric_constants_mod
type(inventory_by_local_mesh_type), target :: long_w2h_inventory_fv

! Heights of DoFs
type(inventory_by_mesh_type), target :: height_w0_inventory_fe
type(inventory_by_mesh_type), target :: height_w0_inventory_fv
type(inventory_by_mesh_type), target :: height_w1_inventory_fe
type(inventory_by_mesh_type), target :: height_w1_inventory_fv
type(inventory_by_mesh_type), target :: height_w2_inventory_fe
Expand Down Expand Up @@ -1185,6 +1187,9 @@ contains

! Determine inventory based on space
select case (space_id)
case (W0)
inventory => height_w0_inventory_fe
inventory_name = "height_w0_fe"
case (W1)
inventory => height_w1_inventory_fe
inventory_name = "height_w1_fe"
Expand Down Expand Up @@ -1255,6 +1260,9 @@ contains

! Determine inventory based on space
select case (space_id)
case (W0)
inventory => height_w0_inventory_fv
inventory_name = "height_w0_fv"
case (W1)
inventory => height_w1_inventory_fv
inventory_name = "height_w1_fv"
Expand Down