-
Notifications
You must be signed in to change notification settings - Fork 39
IO_Demo benchmarking configuration #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MatthewHambley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumed code owner review: The "allow everything" argument is a bit over broad but for a demo application and until we can work out how we actually want to handle the issue of "sleep", I am content.
andrewcoughtrie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me. As mentioned in person could you open an issue to create a sleep function that wraps around C usleep or similar.
Done - #241 |
|
I've just added 2 more commits which just change some of the rose-stem infrastructure around the tests:
I don't think these changes should require further science review, so I'll pass over to @mo-lucy-gordon for CR |
PR Summary
Sci/Tech Reviewer: @andrewcoughtrie
Code Reviewer: @mo-lucy-gordon
This change introduces a flexible benchmarking configuration for the IO_Demo app. The new functionality enables a user to specify a number of fields to write, along with a number of seconds to wait during a step to mimic simulation time. This simple configuration should enable us to exercise the LFRic I/O capability for a number of different use-cases, including writing data at scale.
The changes include:
io_demoto enable new benchmark capabilitysleep()intrinsic for all compilersio_demometadata which allow the app to be controlled a bit more intuitivelyio_demoalgorithm layer to enable it to be stable at scalelaunch-exeto enable running with XIOS servers in the lfric_core rose-stemio_demo_benchmarkgroup which runs at large-ish scale (C224)Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - lfric_core-216-iodemo-bench-vernier/run7
Suite Information
Task Information
✅ succeeded tasks - 377
Test Suite Results - lfric_core - lfric_core-216-iodemo-bench-vernier/run6
Suite Information
Task Information
✅ succeeded tasks - 10
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
[email protected]
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review