release changes - #28
Merged
James Bruten (james-bruten-mo) merged 3 commits intoJun 17, 2026
Merged
Conversation
Pierre Siddall (Pierre-siddall)
approved these changes
Jun 17, 2026
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
Given this is a bump to the version number this looks good to head into testing to me.
Pierre Siddall (Pierre-siddall)
requested a review
from Sam Clarke-Green (t00sa)
June 17, 2026 07:38
Collaborator
|
The project version number in CMakeLists.txt also needs updating to match the version in the header. Once we remove the makefiles, this should become the single source of truth for each version. |
James Bruten (james-bruten-mo)
requested a review
from Pierre Siddall (Pierre-siddall)
June 17, 2026 07:53
Sam Clarke-Green (t00sa)
approved these changes
Jun 17, 2026
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine
James Bruten (james-bruten-mo)
merged commit Jun 17, 2026
cbe0b8a
into
MetOffice:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: Sam Clarke-Green (@t00sa)
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy(including attribution labels)
Documentation
confirmed that it builds correctly
Code Review