Fix Fortran module install path - #32
Merged
James Bruten (james-bruten-mo) merged 1 commit intoJun 30, 2026
Merged
Conversation
James Bruten (james-bruten-mo)
approved these changes
Jun 30, 2026
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
James Bruten (james-bruten-mo)
merged commit Jun 30, 2026
73fd461
into
MetOffice:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: James Bruten (@james-bruten-mo)
Add a trailing slash to prevent Fortran modules from being installed in
install/modulessubdirectory.Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
Comments have been included that aid undertanding and enhance thereadability of the code
My changes generate no new warningsTesting
I have tested this change locally, using the rose-stem suiteIf any tests fail (rose-stem or CI) the reason is understood andacceptable (eg. kgo changes)
I have added tests to cover new functionality as appropriate (eg. systemtests, unit tests, etc.)
Security Considerations
Sensitive data is properly handled (if applicable)Authentication and authorisation are properly implemented (if applicable)Performance Impact
Performance of the code has been considered and, if applicable, suitableperformance measurements have been conducted
AI Assistance and Attribution
Some of the content of this change has been produced with the assistanceof Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy(including attribution labels)
Documentation
Where appropriate I have updated documentation related to this change andconfirmed that it builds correctly
Code Review