Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions source/Reviewers/curaterelease.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ Curating a Release
releases/um_main_release
releases/lfric_apps_release
releases/release_notes
releases/standard_suites
releases/stash_browser
releases/umdp_release
releases/wiki_pages
releases/shared_accounts
releases/updating_prebuilds

.. _reference-tagging:
Expand Down Expand Up @@ -63,11 +66,11 @@ Open a UM X.Y release Curation Ticket, and assign tasks as a team,
|| || LFRic Apps Release || ||
||||||'''Post Release'''||
|| || Release notes || ||
|| || Update standard suites & finalise std jobs page || ||
|| || Update standard suites || ||
|| || Check resource monitoring scripts still work || ||
|| || Install the Stash Browser || ||
|| || Install the Stash Browser || ||
|| || UMDP3 Release || ||
|| || Update wikis, working practices, and create bit comp table || ||
|| || Standard Jobs + Wiki Page || ||
|| || Review and update trunk and shared account permissions || ||

[https://metoffice.github.io/simulation-systems/Reviewers/curaterelease.html Curating a release Page]
Expand Down Expand Up @@ -145,18 +148,11 @@ Post Release Tasks
Most of this can be done pre-release but some details of revision numbers will be dependent on the main release being done.


`Upgrading Standalone Suites <https://code.metoffice.gov.uk/trac/um/wiki/CuratingARelease#UpgradingStandaloneSuites>`_
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:ref:`Updating Standard Suites <standard_suites>`
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

**Dependencies**
UM Release (for UM suites), Apps Release (for Apps suites)


`Standard Jobs Page <https://code.metoffice.gov.uk/trac/um/wiki/CuratingARelease#FinalizeTheStandardJobspage>`_
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

**Dependencies**
UM Release
UM + Apps Releases


`Stash Browser <stash_browser>`
Expand All @@ -173,15 +169,15 @@ UM Release
UM Release, Standard Suites Upgrade


`Wikis Update <https://code.metoffice.gov.uk/trac/um/wiki/CuratingARelease#Updatewikisworkingpracticesandcreatebitcomptable>`_
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:ref:`Standard Jobs and Wiki Pages <wiki_pages>`
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

**Dependencies**
UM Release
UM + Apps Releases


`Shared Account Permissions <https://code.metoffice.gov.uk/trac/um/wiki/CuratingARelease#Reviewandupdatetrunkandsharedaccountpermissions>`_
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:ref:`Trunk and Shared Account Permissions <shared_accounts>`
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

**Dependencies**
None
Expand Down
4 changes: 4 additions & 0 deletions source/Reviewers/releases/partner_testing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ The partner testing period should be 72 hours (3 working days). All tickets affe

* You may need to set the international options in advanced email sending options to use Unicode (UTF-8) as the preferred encoding for outgoing messages to ensure that all international partners receive the email. Change this setting if you receive bounced emails during partner testing.


.. important::

Now is also a good time to ask for the Jules release notes. This is usually done by a member of the Jules community, so email them advising them of the likely release date. Ask the team for their details if unsure.
42 changes: 42 additions & 0 deletions source/Reviewers/releases/shared_accounts.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
.. _shared_accounts:

Trunk and Shared Accounts Permissions
=====================================

.. warning::

Incorrectly editing the svnperms.conf file can break all access to a repo

To update fcm repositories trunk access list (using UM as an example),

* First checkout the top level of the repo,

.. code-block::

fcm co --depth=files https://code.metoffice.gov.uk/svn/um

* Move into the working copy and make the required changes in the ``svnperms.conf`` file.
* Commit the change.

The above process needs doing for all of,

* UM
* LFRic Apps
* Jules
* UKCA
* Casim
* Shumlib
* MOCI

Modify SSD Team Github Permissions:

* https://github.com/orgs/jules-lsm/teams/system-managers
* ​https://github.com/orgs/MetOffice/teams/ssdteam

Review account permissions in Active Directory for the following Shared Users:

* umadmin
* umtest
* julesadmin
* lfricadmin
* spackadmin
96 changes: 96 additions & 0 deletions source/Reviewers/releases/standard_suites.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
.. _standard_suites:

Standard Suites
===============

UM Standard Suites
------------------

For the UM the following Suites must be updated:

* UM Azspice - `u-aa003 <https://code.metoffice.gov.uk/trac/roses-u/browser/a/a/0/0/3/trunk>`_
* UM EX1A - `u-ci752 <https://code.metoffice.gov.uk/trac/roses-u/browser/c/i/7/5/2/trunk>`_
* SCM - `u-aa741 <https://code.metoffice.gov.uk/trac/roses-u/browser/a/a/7/4/1/trunk>`_
* CreateBC - `u-aa258 <https://code.metoffice.gov.uk/trac/roses-u/browser/a/a/2/5/8/trunk>`_

First get a copy of the UM meta trunk, ``fcm co fcm:um_meta.x_tr /path/to/meta/trunk``. Similarly, get a copy of Jules at the most recent release. Then upgrade each suite by doing the following,

* Checkout the suite. ``rosie checkout u-xxNNN`` will put a copy in ``~/roses``.
* Check whether the ``access-list`` in the ``rose-suite.conf`` needs updating - if you are not on it, ask someone to add you now and update your copy once done.
* Move into the suite and edit the ``rose-suite.conf`` file,

* If it has a ``VN`` setting, update it to the new version.
* If it has a ``prebuild`` path, update that now. If there are prebuilds, check the ``flow.cylc`` for any prebuild path overrides. These exist particularly on the EXs.

* Validate the existing apps by running,

.. code-block::

rose macro --fix -C app/APP

where ``APP`` should be replaced by each available app in turn. It should report that 0 changes were made.
* Now upgrade the apps to the new version, using the metadata trunk checked out earlier. Again, replace ``APP`` with each app in turn. This will prompt you to confirm while running.

.. code-block::

rose app-upgrade -C app/APP -M /path/to/the/meta/trunk vnX.Y

* Finally run the validator macros. If everything is fine the command will report nothing, however the SCM suite will raise some warnings about Openmp and "global rows" - these can be ignored.

.. code-block::

rose macro metomi.rose.macros.DefaultValidators -M /path/to/the/meta/trunk:/path/to/the/jules/hot/rose-meta

* Check that the changes look sensible and then run the suite,

.. code-block::

fcm diff -g
cylc vip

.. _suite_commit:

* Once the suite has succeeded, commit the changes (``fcm ci``) with a suitable message and note the revision it was committed at. Then tag the suite and commit the tag,

.. code-block::

fcm pe fcm:revision .
<add tag to resulting editor>
fcm ci


LFRic Apps Standard Suites
--------------------------

For LFRic Apps the following Suites must be updated:

* LFRic Apps Azspice - `u-dn674 <https://code.metoffice.gov.uk/trac/roses-u/browser/d/n/6/7/4/trunk>`_
* LFRic Apps EX1A - `u-dn704 <https://code.metoffice.gov.uk/trac/roses-u/browser/d/n/7/0/4/trunk>`_


For each suite, do the following:

* Get a copy of each of these suites and move into the working copy.

.. code-block::

rosie co u-dn704
cd ~/roses/u-dn704

* In ``rose-suite.conf`` update the version number
* Upgrade the metadata for the mesh and lfric_atm apps

.. code-block::


rose app-upgrade -a -y -C app/lfric_atm vnX.Y
rose app-upgrade -a -y -C app/mesh vnX.Y

* Check the modules loaded in the ``flow.cylc`` for any changes vs. the Apps trunk.

* See ``rose-stem/site/meto/common/suite_config_PLATFORM.cylc``
* The lfric software stack moves more quickly than the UM, so it is more likely these have changed.

* Test - ``cylc vip``
* :ref:`Commit and Tag <suite_commit>` the suite once the test suite has succeeded.

40 changes: 40 additions & 0 deletions source/Reviewers/releases/wiki_pages.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
.. _wiki_pages:

Standard Jobs and Wiki Pages
============================

Standard Jobs Page
------------------

This involves creating a new `Standard Jobs <https://code.metoffice.gov.uk/trac/um/wiki/StandardJobs>`_ for the new release. First update the index page with the new release, then copy the previous release page to the new one, deleting the jobs table within. Check through for all references to the previous release, updating them. Also update the links to the resources pages - we will create these later. Complete a review of the rest of the standard jobs page, updating anything that requires it.

Checkout a copy of the UM trunk at release and then run the following command to create the new standard jobs table,

.. code-block::

./admin/create_stdjobs.py . >> output.txt

Copy the output to the new page.

We also include resource tables used by the suite at release - the links to these pages should have been updated earlier. The resources tables can be generated by running,

.. code-block::

./admin/rose-stem/produce_resources.py /path/to/cylc-run_suite_directory/

This requires a cylc-run directory of the ``all`` group (or individual ones for each platform). Usually the nightly testing from ``umtest`` can be used.


Wiki Pages
----------

Review and update the following pages, modifying version numbers as required:

* Page Templates

* For all of CR, SR and Ticket Summary
* For all of UM, Jules, UKCA, LFRic Apps

* `Bit Comparison Table <https://code.metoffice.gov.uk/trac/um/wiki/LoseBitComparison>`_ - This requires a new page creating
* `Past Releases <https://code.metoffice.gov.uk/trac/um/wiki/PastReleases>`_

2 changes: 1 addition & 1 deletion source/WorkingPractices/documentation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Most notably:

LFRic Apps and Core also use doxygen to document the code and all changes should
include appropriate doxygen changes to go with them. Doxygen guidelines are
available on the `LFRic Technical pages <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/Documentation/DoxygenUsage>`_.
available on the `LFRic Technical pages <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/DoxygenUsage>`_.

.. toctree::
:hidden:
Expand Down