add definitions box - #409
Conversation
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
Good shout adding this
A couple of comments...
| @@ -59,14 +59,24 @@ the process is very comparable to that of the other repositories too. | |||
|
|
|||
| To get started with the ``gh`` cli, see the `gh quickstart guide <https://docs.github.com/en/github-cli/github-cli/quickstart>`_ | |||
|
|
|||
There was a problem hiding this comment.
Is it worth adding a link to the github glossary near this? Something like,
The github glossary https://docs.github.com/en/get-started/learning-about-github/github-glossary_ contains additional definitions to those below
There was a problem hiding this comment.
The mix of markdown and rst didn't work there! I had github glossary as a hyperlink!
| All general development for Simulation Systems Github repos will take place on forks of that repository. It is the responsibility of the developer to maintain their own fork. See :ref:`forking` for advice on forking. | ||
| All general development for Simulation Systems Github repositories will take place on forks of that repository. It is the responsibility of the developer to maintain their own fork. See :ref:`forking` for advice on forking. | ||
|
|
||
| The development cycle can be seen below. ``Upstream`` (blue) refers to parent repository, owned by the MetOffice github organisation. ``Downstream`` (grey) refers to the forked repository, owned by the developer. |
There was a problem hiding this comment.
Do we want to remove the hinting of colours? Or am I getting ahead of myself given this is likely not the final flow design?
There was a problem hiding this comment.
I figured the flow design was likely to change and we can always include a key in the picture or add a note with it around colours once the final thing was sorted.
There was a problem hiding this comment.
Yeah fair enough
Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>
Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
Cheers, looks good
ca0a785
into
MetOffice:github_wps
2 participants
Making the definitions we're using easier to find and adding some initial things to this box. If it gets too big we might want to consider moving it.
Also deleting the files that have been made redundant so far.