rehash review process - #477
Merged
James Bruten (james-bruten-mo) merged 11 commits intoNov 20, 2025
Merged
Conversation
Jenny Hickson (jennyhickson)
marked this pull request as ready for review
November 20, 2025 10:25
Jenny Hickson (jennyhickson)
requested a review
from James Bruten (james-bruten-mo)
November 20, 2025 10:25
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Contributor
There was a problem hiding this comment.
Can we add a note to the scitechreview page saying to tag the code reviewer in some way when passing over the ticket
| Once you are happy that the change is appropriate and correct, and the sci-tech | ||
| review parts of the pull request template have been completed then change | ||
| Once you are happy that the change is appropriate and correct, and the SciTech | ||
| Review parts of the pull request template have been completed then change |
Contributor
There was a problem hiding this comment.
I think we should add a box here saying to either add the CR as a reviewer or tag them in a comment
Collaborator
Author
There was a problem hiding this comment.
turned things the scitech should do into a list, but not in a box. Is that enough?
James Bruten (james-bruten-mo)
approved these changes
Nov 20, 2025
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Contributor
There was a problem hiding this comment.
Yeah, that clarifies that they need to nudge the CR on approval - cheers
James Bruten (james-bruten-mo)
merged commit Nov 20, 2025
9bff364
into
MetOffice:github_wps
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the review process as we keep refining the details.
Also making reviewer terms more consistant and fixing
-\-in macro terms