trac and ticket keyword blat - #480
Merged
Jenny Hickson (jennyhickson) merged 21 commits intoOct 24, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
October 23, 2025 13:01
Jenny Hickson (jennyhickson)
left a comment
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
I've tried to deal with line lengths in my suggestions. Lots of trivial comments...
Comment on lines
+6
to
+10
| Multi-repository changes are expected to pass the regression tests for all the | ||
| repositories involved. To carry out the tests involved in a linked ticket it | ||
| can be helpful to refer to the :ref:`repository figure <multirepo>`; testing | ||
| both child and parent repositories as needed. Further details of how testing | ||
| in each repository is handled can be found on the :ref:`Testing | ||
| page<testing>`. | ||
| repositories involved. To carry out the tests involved in a linked PR it can be | ||
| helpful to refer to the :ref:`repository figure <multirepo>`; testing both child | ||
| and parent repositories as needed. Further details of how testing in each | ||
| repository is handled can be found on the :ref:`Testing page<testing>`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Multi-repository changes are expected to pass the regression tests for all the | |
| repositories involved. To carry out the tests involved in a linked ticket it | |
| can be helpful to refer to the :ref:`repository figure <multirepo>`; testing | |
| both child and parent repositories as needed. Further details of how testing | |
| in each repository is handled can be found on the :ref:`Testing | |
| page<testing>`. | |
| repositories involved. To carry out the tests involved in a linked PR it can be | |
| helpful to refer to the :ref:`repository figure <multirepo>`; testing both child | |
| and parent repositories as needed. Further details of how testing in each | |
| repository is handled can be found on the :ref:`Testing page<testing>`. | |
| Multi-repository changes are expected to pass the regression tests for all the | |
| repositories involved. To carry out the tests involved in a linked pull request it | |
| can be helpful to refer to the :ref:`repository figure <multirepo>`; testing both | |
| child and parent repositories as needed. Further details of how testing in each | |
| repository is handled can be found on the :ref:`Testing page<testing>`. |
Contributor
Author
There was a problem hiding this comment.
Done
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks, all done
Comment on lines
+6
to
+10
| Multi-repository changes are expected to pass the regression tests for all the | ||
| repositories involved. To carry out the tests involved in a linked ticket it | ||
| can be helpful to refer to the :ref:`repository figure <multirepo>`; testing | ||
| both child and parent repositories as needed. Further details of how testing | ||
| in each repository is handled can be found on the :ref:`Testing | ||
| page<testing>`. | ||
| repositories involved. To carry out the tests involved in a linked PR it can be | ||
| helpful to refer to the :ref:`repository figure <multirepo>`; testing both child | ||
| and parent repositories as needed. Further details of how testing in each | ||
| repository is handled can be found on the :ref:`Testing page<testing>`. |
Contributor
Author
There was a problem hiding this comment.
Done
Comment on lines
+17
to
+21
| A technical review of the changes involved in the PR, including checks | ||
| that code standards have been upheld and that the working practices have | ||
| been followed. These reviews are generally completed by a member of the | ||
| Simulation Systems and Deployment Team. Once a review has been approved | ||
| the Code Systems Reviewer is then responsible for committing the change to | ||
| the trunk. | ||
|
|
||
| .. | ||
| or the Core Capability Development Team (for LFRic only reviews). | ||
| Simulation IT Team. Once a review has been approved the Code Systems | ||
| Reviewer is then responsible for committing the change to the trunk. |
Contributor
Author
There was a problem hiding this comment.
Done
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
October 24, 2025 09:00
Jenny Hickson (jennyhickson)
approved these changes
Oct 24, 2025
Jenny Hickson (jennyhickson)
merged commit Oct 24, 2025
f74a702
into
MetOffice:github_wps
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes examples of ticket and trac from working practices