update most references to trac wiki - #487
Merged
Jenny Hickson (jennyhickson) merged 6 commits intoOct 30, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
October 29, 2025 08:35
Jenny Hickson (jennyhickson)
left a comment
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
trivial suggestions, but generally good and ready to go
Comment on lines
+113
to
+115
| * :ref:`UMDP3 (UM and JULES FORTRAN) <umdp3>` | ||
| * `LFRic Coding Styles | ||
| <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/CodingStandards>`__ | ||
| * `PEP 8 (Python) <https://legacy.python.org/dev/peps/pep-0008/>`__ | ||
|
|
||
| `This page | ||
| <https://code.metoffice.gov.uk/trac/um/wiki/CodeReviewCribSheet>`__ | ||
| provides some common (though UM-centric) things to confirm and think | ||
| about. It is not an exhaustive list, just a starting point. | ||
| <https://metoffice.github.io/lfric_core/how_to_contribute/coding_standards/fortran_coding_standards.html>`__ |
Collaborator
There was a problem hiding this comment.
Do the same here as above
Contributor
Author
There was a problem hiding this comment.
Done
| <https://code.metoffice.gov.uk/doc/um/latest/papers/umdp_003.pdf>`__ or | ||
| `LFRic Coding Styles | ||
| <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/CodingStandards>`__. | ||
| * Ensure that the code is written to the standards laid out in |
Collaborator
There was a problem hiding this comment.
and again 😄
Contributor
Author
There was a problem hiding this comment.
Yeah I was anticipating that!
Comment on lines
+61
to
+63
| <https://github.com/MetOffice/jules/wiki/sharing_jules_metadata>`__ | ||
| and in `jules-standalone, jules-lfric or um-atmos | ||
| <https://code.metoffice.gov.uk/trac/jules/wiki/SharingJULESmetadata#Whatsinjules-standalonejules-lfricorum-atmos>`__. | ||
| <https://github.com/MetOffice/jules/wiki/sharing_jules_metadata>`__. |
Collaborator
There was a problem hiding this comment.
Did these want to still be sublinks to different parts of the page?
Contributor
Author
There was a problem hiding this comment.
Yeah not sure why I didn't keep those
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Contributor
Author
There was a problem hiding this comment.
Cheers, all done
Comment on lines
+61
to
+63
| <https://github.com/MetOffice/jules/wiki/sharing_jules_metadata>`__ | ||
| and in `jules-standalone, jules-lfric or um-atmos | ||
| <https://code.metoffice.gov.uk/trac/jules/wiki/SharingJULESmetadata#Whatsinjules-standalonejules-lfricorum-atmos>`__. | ||
| <https://github.com/MetOffice/jules/wiki/sharing_jules_metadata>`__. |
Contributor
Author
There was a problem hiding this comment.
Yeah not sure why I didn't keep those
Comment on lines
+113
to
+115
| * :ref:`UMDP3 (UM and JULES FORTRAN) <umdp3>` | ||
| * `LFRic Coding Styles | ||
| <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/CodingStandards>`__ | ||
| * `PEP 8 (Python) <https://legacy.python.org/dev/peps/pep-0008/>`__ | ||
|
|
||
| `This page | ||
| <https://code.metoffice.gov.uk/trac/um/wiki/CodeReviewCribSheet>`__ | ||
| provides some common (though UM-centric) things to confirm and think | ||
| about. It is not an exhaustive list, just a starting point. | ||
| <https://metoffice.github.io/lfric_core/how_to_contribute/coding_standards/fortran_coding_standards.html>`__ |
Contributor
Author
There was a problem hiding this comment.
Done
| <https://code.metoffice.gov.uk/doc/um/latest/papers/umdp_003.pdf>`__ or | ||
| `LFRic Coding Styles | ||
| <https://code.metoffice.gov.uk/trac/lfric/wiki/LFRicTechnical/CodingStandards>`__. | ||
| * Ensure that the code is written to the standards laid out in |
Contributor
Author
There was a problem hiding this comment.
Yeah I was anticipating that!
Jenny Hickson (jennyhickson)
approved these changes
Oct 30, 2025
Jenny Hickson (jennyhickson)
left a comment
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks
Jenny Hickson (jennyhickson)
merged commit Oct 30, 2025
827c03d
into
MetOffice:github_wps
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update most of the references to code.metoffice.gov.uk/*
A couple of new wiki pages have been created
Remaining ones: