Radaer api ukca side - part two initialisation

[Alan J Hewitt (alanjhewitt)]

PR Summary

This change allows users to change the GLOMAP setting (i_mode_setup) that is passed to RADAER.

Sci/Tech Reviewer: Mohit Dalvi (@mcdalvi)
Code Reviewer: Pierre Siddall (@Pierre-siddall)

This development increases the flexibility of RADAER so that when called from LFRic_apps parent with setting GLOMAP_MODE_UKCA RADAER will run with the setting of i_mode_setup.

When called from LFRic_apps parent with setting GLOMAP_MODE_CLIMATOLOGY RADAER will run with the fixed setting of SUBCOCSSDU_7mode. This preserves the existing functionality but replaces hard coded settings in radaer_kernel_mod.

When called from LFRic_apps parent with setting GLOMAP_MODE_DUST_AND_CLIM UKCA will run with fixed setting DUonly_2modes and RADAER will run with the fixed setting of SUBCOCSSDU_7mode. This preserves the existing functionality but replaces hard coded settings in radaer_kernel_mod.

Lists used by radaer_kernel_mod are SAVED and stored in UKCA modules
n_ukca_mode and n_ukca_cpnt used by radaer_kernel_mod are SAVED and stored in UKCA modules.

• linked Radaer api la side - part two initialisation lfric_apps#698

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings

Testing

• I have tested this change locally, using the UKCA rose-stem suite
• If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
• I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

I have run UKCA box model test with suite u-dr481

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable
  performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[github-actions]

⚠️ Hello Alan J Hewitt (@alanjhewitt)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

[Alan J Hewitt (alanjhewitt)]

Hi Mohit,

this development is now ready for SciTech review.

Alan

[Mohit Dalvi (mcdalvi)]

Could ukca_radaer_lfric be declared in the 'struct_mod' itself, avoiding the need for this module? The ukca_radaer_lfric_struct_mod will need to be accessed by calling/ downstream routines in any case.

If module is to be retained: check copyright statement (should be LICENCE file) and add ownership details

[Mohit Dalvi (mcdalvi)]

Correct the RoutineName

[Mohit Dalvi (mcdalvi)]

Check copyright statement (should be LICENCE file).

[Mohit Dalvi (mcdalvi)]

Does the structure/ instance stay in memory throughout, or is there a need for a 'deallocate' routine?