feat!: make getAccounts() synchronous
#378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
changed the title
getAccount() synchronousgetAccounts() synchronous
danroc
force-pushed
the
dr/sync-get-accounts
branch
from
119133f to
f063652
Compare
danroc
force-pushed
the
dr/sync-get-accounts
branch
from
f063652 to
3ef9922
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
danroc
commented
Sep 12, 2025
|
|
||
| expect(await keystoneKeyring.getAccounts()).toStrictEqual( | ||
| await keystoneKeyring.getAccounts(), | ||
| keyring.getAccounts(), |
There was a problem hiding this comment.
I suspect that the original tests were incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes synchronous the
getAccounts()method of the keyrings to ensure safe invocation within synchronous functions. Additionally, it modifies theKeyringinterface to make the list of accounts readily available and prevent blocking operations inside thegetAccounts()method.BREAKING: This PR changes the signature of the
getAccounts()method to make it synchronous.