preferences-controller: moved keyring controller to runtime dependency

[kanthesha]

Explanation

@metamask/keyring-controller should be a runtime dependency, not a development dependency.
It's already a peer dependency, so it should be a runtime dependency too.

References

• Fixes [preferences-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency #4478

Changelog

@metamask/preferences-controller

• FIXED: Moved @metamask/keyring-controller from devDependency to runtime dependency

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[Gudahtt]

It's already a peer dependency, so it should be a runtime dependency too

The opposite is true; a peer dependency should never be a dependency. If we're listing it as a peer dependency, it means that we don't know which version is needed to use the package correctly, so we cannot include it as a regular dependency.