Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand notification args #4682

Merged
merged 8 commits into from
Sep 24, 2024
Merged

feat: Expand notification args #4682

merged 8 commits into from
Sep 24, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Sep 10, 2024

Explanation

  • What is the current state of things and why does it need to change? The notification controller cannot accommodate "expanded view" snaps notifications
  • What is the solution your changes offer and how does it work? The extra properties being sent with the show method will now be persisted as well so the extension can use it to show JSX content for snaps within an expanded view of a notification.

Changelog

@metamask/notification-controller

  • CHANGED: show function's arguments to be an object so we can persist the extra properties needed to show JSX content in snap notifications.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@hmalik88 hmalik88 requested a review from a team as a code owner September 10, 2024 21:55
@hmalik88 hmalik88 changed the title feat: Expand notification type feat: Expand notification args type Sep 10, 2024
@hmalik88 hmalik88 changed the title feat: Expand notification args type feat: Expand notification args Sep 10, 2024
@hmalik88 hmalik88 merged commit 6b7bf84 into main Sep 24, 2024
116 checks passed
@hmalik88 hmalik88 deleted the hm/expand-notification-type branch September 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants