Skip to content

refactor: migrate AppMetadataController to @metamask/messenger #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

refactor: migrate AppMetadataController to @metamask/messenger #6385

wants to merge 13 commits into from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Aug 26, 2025 •
edited
Loading

Explanation

This PR migrates the AppMetadataController class to the new @metamask/messenger comm system, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito marked this pull request as ready for review August 26, 2025 12:32
@mikesposito mikesposito requested review from a team as code owners August 26, 2025 12:32
cursor[bot]

This comment was marked as outdated.

Sign in to view

@mikesposito mikesposito mentioned this pull request Aug 26, 2025
Open
42 tasks
mcmire
mcmire previously approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Copy link
Contributor

mcmire commented Aug 28, 2025

It's unclear to me why the code scanner workflow is failing. I don't see any issues.

@mikesposito mikesposito enabled auto-merge (squash) September 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mcmire mcmire mcmire left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @mcmire