-
-
Notifications
You must be signed in to change notification settings - Fork 248
feat: check against urls with path #6416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imblue-dabadee
wants to merge
69
commits into
main
Choose a base branch
from
feat/check-against-urls-with-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
b0d948f
feat: add blocklistPaths
imblue-dabadee e85956f
feat: doesURLPathExist
imblue-dabadee f972d6e
test: doesURLPathExist
imblue-dabadee 7693283
feat: add and removals to blocklistPaths
imblue-dabadee e6bfad7
refactor: increase addURLToBlocklistPaths readability
imblue-dabadee ec9d635
fix: add httpPrefix to use URL correctly
imblue-dabadee 1c20cb5
fix: removeURLFromBlocklistPaths respects hierachy
imblue-dabadee 72a42aa
fix: handle for longer than 3 paths being added and removed
imblue-dabadee 7e071ab
tests: applyDiffs
imblue-dabadee 9da68b0
refactor: generic functions and remove helper
imblue-dabadee 8b2a573
lint: fix
imblue-dabadee 37d1401
chore: update the tag names
imblue-dabadee 42d92ed
Merge branch 'main' into feat/check-against-urls-with-path
imblue-dabadee de20842
Merge branch 'main' into feat/check-against-urls-with-path
imblue-dabadee 7d1f82b
Merge branch 'main' into feat/check-against-urls-with-path
imblue-dabadee 7e9b3a5
feat: whitelist support
imblue-dabadee 4854c2b
test: update snapshot
imblue-dabadee 0dc4d5b
fix: add only hostname with paths to whitelist
imblue-dabadee a929ba9
test: bypass whitelistPaths
imblue-dabadee 095f60a
fix: test only checks hostnames with apths
imblue-dabadee 5bd9365
test: test for whitelistPaths
imblue-dabadee cb623ef
feat: PathTrie
imblue-dabadee 1179b55
test: PathTrie
imblue-dabadee ef1e114
chore: update types for blocklistPaths to Trie
imblue-dabadee a6b535b
chore: remove old insertion/deletion/exists methods
imblue-dabadee cbfa2a5
test: update to new structure
imblue-dabadee a98edbb
refactor: getHostnameAndPathComponents
imblue-dabadee 80927ec
fix: separate blocklist entries
imblue-dabadee be8202d
test: separateBlocklistEntries
imblue-dabadee f283e11
test: getHostnameAndPathComponents
imblue-dabadee 22b1ad1
test(fix): updateStalelist unit test
imblue-dabadee d337406
test: subdomain case getHostnameAndPathComponents
imblue-dabadee a593944
test(fix): update the structure of blocklistPaths
imblue-dabadee 907dd00
test: updateStalelist blocklist separation case
imblue-dabadee 8578fac
test(fix): add mocks
imblue-dabadee 277ada7
test(fix): add url to blocklistPaths before calling bypass
imblue-dabadee 6b4742a
fix: check that blocklistPaths is empty or undefined
imblue-dabadee 09fbe61
refactor: remove old funcs
imblue-dabadee 598b78a
test: check tests path-based blocking version
imblue-dabadee 4f98f31
test: isPathBlocked
imblue-dabadee f8eed59
fix: update getDefaultPhishingDetectorConfig
imblue-dabadee 2cd8146
fix: revert processConfigs
imblue-dabadee 03714bc
fix: remove blocklist separation in getDefaultPhishingDetectorConfig
imblue-dabadee 80882f7
chore: redundant return variable
imblue-dabadee 5de9179
test: update tests
imblue-dabadee ed9a836
fix: lint issues
imblue-dabadee 9368c52
Merge branch 'main' into feat/check-against-urls-with-path
imblue-dabadee 302d40e
fix: update PhishingStalelist to use flat structure
imblue-dabadee 477f90c
test: phishing list is replaced if different in maybeUpdateState
imblue-dabadee 6d194f1
fix: remove eth_phishing_detect_config from PhishingListState
imblue-dabadee 42eb75d
test: update tests to use flat structure
imblue-dabadee 89e231b
chore: update lint issues
imblue-dabadee 655bc55
refactor: update to handle blocklistPaths as targetListState
imblue-dabadee 6b66b65
test: update applyDiffs targetList
imblue-dabadee 791a413
util: convert convertListToTrie
imblue-dabadee 7b73abc
test: convertListToTrie
imblue-dabadee 80d2078
refactor: blocklistPaths in controller
imblue-dabadee c0eb43b
test: update for blocklistPaths
imblue-dabadee 50f84b5
chore: remove unused func
imblue-dabadee a7929be
fix: lint
imblue-dabadee eedc5cd
chore: lint
imblue-dabadee 9ed30c3
Merge remote-tracking branch 'origin/main' into feat/check-against-ur…
imblue-dabadee e3c0656
chore: update test
imblue-dabadee 0b4bb58
feat: deepCopyPathTrie
imblue-dabadee 8eaa822
test: deepCopyPathTrie
imblue-dabadee 88011a0
fix: add deepCopyPathTrie to applyDiffs
imblue-dabadee 412452c
test: update applyDiffs
imblue-dabadee 5f2b5e6
chore: fix lint issue
imblue-dabadee 46d1e34
chore: update CHANGELOG
imblue-dabadee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be modifying this file should we ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! This file gets automatically updated when you run
yarn lint, it's okay to modify and commit this. The goal of this file is to track how many lint warnings there are so we can slowly remove them (it's a tech debt kind of thing). Only thing I would say is that the numbers in this file should go down.