Skip to content

refactor: migrate AccountsController to @metamask/messenger #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor: migrate AccountsController to @metamask/messenger #6426

wants to merge 14 commits into from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 1, 2025 •
edited
Loading

Explanation

This PR migrates AccountsController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the add-disable-namespace-feature branch from c91dd1c to ba39ec4 Compare September 2, 2025 13:41
Base automatically changed from add-disable-namespace-feature to main September 2, 2025 15:17
@mikesposito mikesposito force-pushed the mikesposito/messenger/accounts-controller branch from 8f8b7a0 to 3453a8d Compare September 3, 2025 09:41
@mikesposito mikesposito mentioned this pull request Sep 3, 2025
Open
42 tasks
@mikesposito mikesposito marked this pull request as ready for review September 3, 2025 15:02
@mikesposito mikesposito requested review from a team as code owners September 3, 2025 15:02
mcmire
mcmire previously approved these changes Sep 10, 2025
View reviewed changes
@mikesposito mikesposito enabled auto-merge (squash) September 23, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @mcmire