refactor: migrate AccountsController to @metamask/messenger
#6426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-disable-namespace-feature
branch
from
c91dd1c to
ba39ec4
Compare
mikesposito
force-pushed
the
mikesposito/messenger/accounts-controller
branch
from
8f8b7a0 to
3453a8d
Compare
43 tasks
mcmire
previously approved these changes
Sep 10, 2025
Co-authored-by: Elliot Winkler <[email protected]>
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
AccountsControllerto the new@metamask/messengermessage bus, as opposed to the one exported from @metamask/base-controller.References
Checklist
Note
Migrates AccountsController to the new @metamask/messenger API, updating code, tests, metadata, and project references.
@metamask/messengerand@metamask/base-controller/next; replaceRestrictedMessengerandmessagingSystem.*withMessengerandmessenger.*APIs.Messenger,ExtractEventPayload).includeInDebugSnapshot: false).Messengerand a namespacedAccountsControllermessenger; spy on controller messenger publishes.deriveStateFromMetadatafrombase-controller/next.@metamask/messengerand TS project references; updatetsconfig*.jsonandyarn.lock.@metamask/messengerandaccounts_controller --> messenger.Written by Cursor Bugbot for commit 74f2117. This will update automatically on new commits. Configure here.