Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 7, 2025

Explanation

Ignore transactions with isTransfer set when checking for duplicate nonces in PendingTransactionTracker.

References

Related to #6135

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Prevents pending transactions from being marked dropped when their nonce matches an incoming/transfer transaction by refining the nonce-taken check.

  • PendingTransactionTracker:
    • Refine #isNonceTaken to exclude transactions where tx.type !== incoming AND tx.isTransfer !== undefined, avoiding false duplicate-nonce drops from incoming/transfer transactions.
    • Add unit test ensuring no transaction-dropped event when a matching nonce belongs to an incoming transaction.
  • Changelog:
    • Document fix: prevent transactions marked as dropped if nonce matches incoming transaction.

Written by Cursor Bugbot for commit 77e52f5. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 7, 2025 22:58
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 7, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants