refactor: deprecate transaction history and sendFlowHistory properties
#7326
+43
−1,250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
vinistevam
changed the title
history and sendFlowHistory properties
Contributor
Author
|
Extension draft PR: MetaMask/metamask-extension#38665 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| readonly #trace: TraceCallback; | ||
|
|
||
| readonly #transactionHistoryLimit: number; | ||
| // readonly #transactionHistoryLimit: number; |
There was a problem hiding this comment.
Bug: Commented-out code left in production code
A commented-out line // readonly #transactionHistoryLimit: number; was left in the codebase. This appears to be leftover from the deprecation process where the #transactionHistoryLimit property was removed but the line was commented out instead of being fully deleted.
matthewwalsh0
requested changes
Dec 11, 2025
| /** TransactionController constructor options. */ | ||
| export type TransactionControllerOptions = { | ||
| /** Whether to disable storing history in transaction metadata. */ | ||
| /** @deprecated Whether to disable storing history in transaction metadata. */ |
Member
There was a problem hiding this comment.
Can we update all the deprecated comments to just confirm No longer used for example?
| readonly #trace: TraceCallback; | ||
|
|
||
| readonly #transactionHistoryLimit: number; | ||
| // readonly #transactionHistoryLimit: number; |
Member
There was a problem hiding this comment.
This isn't related to the history properties, but how many transactions we retain. We need to keep this.
| ); | ||
|
|
||
| this.update((state) => { | ||
| state.transactions = this.#trimTransactionsForState(newTransactions); |
Member
There was a problem hiding this comment.
We still need to trim the transactions according to the transaction state limit?
| ...transactionMeta, | ||
| })); | ||
|
|
||
| log(`Transaction ${transactionId} updated. ${note}`); |
Member
There was a problem hiding this comment.
Suggested change
| log(`Transaction ${transactionId} updated. ${note}`); | |
| log('Transaction updated', {transactionId, note}); |
| * @param sendFlowHistoryToAdd - The sendFlowHistory entries to add. | ||
| * @returns The updated transactionMeta. | ||
| */ | ||
| updateTransactionSendFlowHistory( |
Member
There was a problem hiding this comment.
If we're avoiding breaking changes in this PR, should we empty this and mark it deprecated?
| it('does not if all unique transactions are truncated', async () => { | ||
| const helper = new IncomingTransactionHelper({ | ||
| ...CONTROLLER_ARGS_MOCK, | ||
| trimTransactions: (): TransactionMeta[] => [], |
Member
There was a problem hiding this comment.
Still needed as mentioned in other comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR deprecates the
historyandsendFlowHistoryproperties and all the code related.Problem
Extension state size has been identified as a major root cause for the app becoming bricked, particularly for power users. Analysis by the platform team revealed that
historyandsendFlowHistoryare among the biggest contributors to excessive state size, leading to frequent disk writes and the infinite spinner issue.References
fixes https://github.com/MetaMask/MetaMask-planning/issues/2465
Checklist
Note
Deprecates
history/sendFlowHistoryand removes all internal history recording/trimming, simplifying incoming tx handling and updating types, tests, and exports.TransactionMeta.historyandsendFlowHistoryas deprecated; deprecatedisableHistory,disableSendFlowHistory, andtransactionHistoryLimitoptions.utils/history.*) and related tests; stop creating/updating history snapshots.#trimTransactionsForState, history notes);updateTransactionnow logs note only.updateTransactionSendFlowHistoryAPI and all send-flow history handling.DISPLAYED_TRANSACTION_HISTORY_PATHS,MAX_TRANSACTION_HISTORY_LENGTH).Written by Cursor Bugbot for commit 87558a8. This will update automatically on new commits. Configure here.