feat: improve token detection #7408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
| | NetworkControllerGetNetworkClientByIdAction | ||
| | NetworkControllerGetStateAction | ||
| | TokensControllerGetStateAction | ||
| | TokenDetectionControllerAddDetectedTokensViaPollingAction |
Comment on lines
+161
to
+162
| | KeyringControllerLockEvent | ||
| | KeyringControllerUnlockEvent |
Contributor
There was a problem hiding this comment.
Nice bug fix to prevent calls when wallet is locked!
Comment on lines
+165
to
+167
| | AccountsControllerSelectedEvmAccountChangeEvent | ||
| | TransactionControllerTransactionConfirmedEvent | ||
| | TransactionControllerIncomingTransactionsReceivedEvent; |
Contributor
There was a problem hiding this comment.
Nice bug fix to ensure the wallet balances and tokens update from various events related to TX updates or Account selection changes.
Prithpal-Sooriya
approved these changes
Dec 11, 2025
Comment on lines
+811
to
+818
| if (!this.#useTokenDetection()) { | ||
| return; | ||
| } | ||
|
|
||
| // Check if external services are enabled (websocket requires external services) | ||
| if (!this.#useExternalServices()) { | ||
| return; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Extension UI: MetaMask/metamask-extension#38708
Mobile UI: MetaMask/metamask-mobile#23864
Acceptance Criteria
• Replace all Account API v2 calls with Account API v4 for token auto-detection.
• Continue using RPC-based detection for chains not supported by Account API v4.
• If Account API v4 requests fail, fallback to RPC-based token detection.
• If Account API v4 returns any unprocessed networks, fallback to RPC detection for those networks as well.
References
Checklist
Note
Replaces token auto-detection via Accounts API v2 with v4, delegating supported chains to TokenBalancesController, adding RPC fallbacks/new actions, and improving polling, lock handling, and tests.
TokenDetectionController.detectTokens()addsforceRpcand is exposed viaTokenDetectionController:detectTokens.addDetectedTokensViaPollingand enhancesaddDetectedTokensViaWs; respects prefs/external services; metrics tracking.TokenDetectionController:detectTokenswithforceRpc: true.TokenDetectionController:addDetectedTokensViaPolling.isActive), transaction events handling, per-chain polling grouping/updates, token address filtering, and robust state normalization.unprocessedNetworks, maps to hex; maintains timeout/batching; staked balances handling.index.tsexports for new actions; changelog documents breaking changes and new flows.Written by Cursor Bugbot for commit 10463da. This will update automatically on new commits. Configure here.