feat: Adding requestId field to dapp confirmations

[jpuri]

Explanation

The PR adds id from the JSON RPC request to the transaction meta object. Thus change is done at 2 places:

1. Transaction controller
2. EIP-5792 middleware

References

Related to #67890

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Propagates the JSON-RPC request id into transaction metadata for single and batched flows, wiring through EIP-5792 middleware and TransactionController with updated types, tests, and changelogs.

• Transaction Controller:
  • Add requestId to TransactionMeta, TransactionBatchMeta, AddTransactionOptions, and TransactionBatchRequest.
  • Plumb requestId through addTransaction, addTransactionBatch, and batch utilities (utils/batch.ts).
  • Update tests to reflect new metadata field.
• EIP-5792 Middleware:
  • Extract req.id and pass as requestId to addTransaction/addTransactionBatch in processSendCalls.
  • Adjust tests to assert requestId propagation.
• Changelogs:
  • Document addition of requestId across both packages.

^{Written by Cursor Bugbot for commit e854e88. This will update automatically on new commits. Configure here.}

[OGPoyraz]

What if we use JsonRpcId type from @metamask/utils in the TransactionController types? As v2 JSONRpcEngine referring the same types https://github.com/MetaMask/core/blob/main/packages/json-rpc-engine/src/v2/JsonRpcEngineV2.ts#L4

Then we wouldn't really need to cast here and just pass as is?

[jpuri]

String is I think more useful even later when we use it in the UI

[OGPoyraz]

Sorry not sure I follow, what makes string to be useful and how's that related with UI?

It's a minor thing for sure, but am not completely convinced if casting here necessary. So I will defer this to @dan437

[OGPoyraz]

Do we want to note additions in changelog on this package and transaction-controller?

[jpuri]

Good point, let me do that.