Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 10, 2025

Explanation

This fixes all suppressed ESLint errors in the polling-controller package.

References

Closes #7383.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Adds explicit return types and targeted ESLint-disable annotations to polling controller mixins and tests, removing related suppressions.

  • Polling Controller:
    • BlockTrackerPollingController (packages/polling-controller/src/BlockTrackerPollingController.ts):
      • Add explicit return types to _startPolling and _stopPollingByPollingTokenSetId.
      • Document/annotate mixin factory and exported helpers with ESLint disables for inferred return types.
    • StaticIntervalPollingController (packages/polling-controller/src/StaticIntervalPollingController.ts):
      • Add explicit return types to setIntervalLength, getIntervalLength, _startPolling, and _stopPollingByPollingTokenSetId.
      • Document/annotate mixin factory and exported helpers with ESLint disables for inferred return types.
    • Tests (packages/polling-controller/src/StaticIntervalPollingController.test.ts):
      • Rename callback param err to error in deferred promise handlers.
  • ESLint Suppressions:
    • Remove suppressions for updated polling-controller files in eslint-suppressions.json.

Written by Cursor Bugbot for commit 91d0c5a. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review December 11, 2025 09:37
@Mrtenz Mrtenz requested a review from a team as a code owner December 11, 2025 09:37
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 845352d Dec 12, 2025
285 of 286 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-lint-polling-controller branch December 12, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix suppressed lint errors in polling-controller

3 participants