chore: Update team json file for commits.csv during create release pr #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (response.status !== 200 || !response.data) { | ||
| console.error( | ||
| `Invalid response when fetching teams.json: ${response.status}`, | ||
| `Invalid response when fetching topology.json: ${response.status}`, |
There was a problem hiding this comment.
Bug: JSON structure mismatch causes all teams to return Unknown
The topology.json file has a different structure than the old teams.json. The new file is an array of team objects containing members, pm, em, tl, and githubLabel fields (as shown in .github/actions/add-team-label/action.yml). However, the code still uses teamsJson[author] which expects a flat object keyed by username. Since topology.json is an array and author is a username string, this lookup will always return undefined, causing all commits to be labeled as 'Unknown'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3180
Fix bug discussed here https://consensys.slack.com/archives/C09B64PEHAQ/p1764576026224679.
Update create-release-pr workflow to use new topology.json) instead of old teams.json file which no longer exists to create commits.csv.
Note
Switches team lookup from teams.json to topology.json in commit-to-team mapping for commits.csv generation.
getTeamin.github/scripts/generate-rc-commits.mjsto fetchtopology.jsoninstead ofteams.jsonfor author-to-team mapping.Written by Cursor Bugbot for commit 2641000. This will update automatically on new commits. Configure here.