generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: brand evolution updates part 1 #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49765d3
to
bc4b874
Compare
Updated hover & pressed values for all colors, except some muted colors that were already up-to-date.
Updated all hover & pressed colors except for "muted" colors as they are already up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comment alignment (I'll push an update)
brianacnguyen
approved these changes
Mar 12, 2025
This was referenced Mar 12, 2025
brianacnguyen
added a commit
that referenced
this pull request
Mar 12, 2025
## Description This PR updates the design tokens to align with the brand evolution "blurple" colors and fixes some casing inconsistencies introduced in #428. The changes primarily affect the blue color palette across our design system, ensuring consistency between Figma values and our implementation. Key updates include: 1. Updating the blue color scale in brand colors from the current palette to the new "blurple" palette 2. Adjusting primary, info, and shadow colors in both light and dark themes to use the new blue values 3. Fixing casing consistency in color values to ensure they match Figma exactly ## Related issues Fixes: #475 ## Manual testing steps 1. Pull the branch and build storybook `yarn storybook` 2. Verify that all blue colors have been updated to the new "blurple" palette 3. Check that primary colors in both light and dark themes reflect the new values 4. Confirm that all color hex values match their comments exactly (casing) 5. Run tests using `yarn workspace @metamask/design-tokens jest src/js` to verify changes ## Screenshots/Recordings ### Before Blue color values (old): - Blue500: `#0376c9` - Blue300: `#43aefc` - Primary default (light): `#0376c9` - Primary default (dark): `#43aefc` https://github.com/user-attachments/assets/c847b5c1-0777-49b6-a1d5-3ad65e5f6259 ### After Blue color values (new): - Blue500: `#4459ff` - Blue300: `#8b99ff` - Primary default (light): `#4459ff` - Primary default (dark): `#8b99ff` https://github.com/user-attachments/assets/e40b5971-5eae-4382-a54b-12125ea2f24f ## Pre-merge author checklist - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR ## Pre-merge reviewer checklist - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed) - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots --------- Co-authored-by: Brian August Nguyen <[email protected]> Co-authored-by: Hiro M <[email protected]>
georgewrmarshall
added a commit
that referenced
this pull request
Mar 18, 2025
## **Description** This release includes: 1. Monorepo version bump to 3.0.0 2. Initial release of `@metamask/design-system-tailwind-preset` at v0.1.0 (beta release) 3. Version bump of `@metamask/design-tokens` to v5.1.0 with brand evolution updates Key changes: - Brand evolution updates including changing blue to "blurple" (#474, #428) - Initial release of the Tailwind preset package - Various dependency and infrastructure updates ## **Related issues** Fixes: - Brand evolution color updates (#474, #428) - Initial Tailwind preset package release ## **Manual testing steps** 1. Check changelog entries align with changes 2. Verify package version bumps: - Root package: 2.0.0 -> 3.0.0 - design-tokens: 5.0.0 -> 5.1.0 - design-system-tailwind-preset: 0.0.0 -> 0.1.0 3. Verify brand evolution color changes are correctly reflected ## **Screenshots/Recordings** N/A - Infrastructure and design token changes ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our design token colors to align with the brand evolution colors, with the exception of blue (blurple) colors. This strategic update helps prevent color definitions from becoming stale and reduces the maintenance footprint for future color updates.
The changes primarily affect the
brandColor.types.ts
file, updating various color tokens across our palette including grey, green, red, yellow, orange, purple, and lime color scales.Related issues
Fixes: #392
Manual testing steps
yarn storybook
Screenshots/Recordings
Before
TBC
After
To be finalized
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist