-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fixed socket security error for RN - jazzicon #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we can close this in favor of #468 |
"minimist": "1.2.6", | ||
"node-fetch": "^2.6.7", | ||
"xmldom": "npm:@xmldom/[email protected]", | ||
"@walletconnect/socket-transport/ws": "^7.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"node-fetch": "^2.6.7", | ||
"xmldom": "npm:@xmldom/[email protected]", | ||
"@walletconnect/socket-transport/ws": "^7.5.10", | ||
"@ethersproject/providers/ws": "^7.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"xmldom": "npm:@xmldom/[email protected]", | ||
"@walletconnect/socket-transport/ws": "^7.5.10", | ||
"@ethersproject/providers/ws": "^7.5.10", | ||
"puppeteer-core/ws": "^8.17.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@walletconnect/socket-transport/ws": "^7.5.10", | ||
"@ethersproject/providers/ws": "^7.5.10", | ||
"puppeteer-core/ws": "^8.17.1", | ||
"react-native/ws": "^6.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR fixes the security error introduced with
react-native-jazzicon
libraryRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist