Skip to content

Conversation

brianacnguyen
Copy link
Contributor

Description

This PR fixes the security error introduced with react-native-jazzicon library

Related issues

Fixes:

Manual testing steps

  1. N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall
Copy link
Contributor

@SocketSecurity

@georgewrmarshall
Copy link
Contributor

I think we can close this in favor of #468

"minimist": "1.2.6",
"node-fetch": "^2.6.7",
"xmldom": "npm:@xmldom/[email protected]",
"@walletconnect/socket-transport/ws": "^7.5.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like @walletconnect is in our dependency tree?

Screenshot 2025-03-06 at 3 23 09 PM

"node-fetch": "^2.6.7",
"xmldom": "npm:@xmldom/[email protected]",
"@walletconnect/socket-transport/ws": "^7.5.10",
"@ethersproject/providers/ws": "^7.5.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like @ethersproject/providers/ws is in our dependency tree?

Screenshot 2025-03-06 at 3 24 05 PM

"xmldom": "npm:@xmldom/[email protected]",
"@walletconnect/socket-transport/ws": "^7.5.10",
"@ethersproject/providers/ws": "^7.5.10",
"puppeteer-core/ws": "^8.17.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like puppeteer-core/ws is in our dependency tree?

Screenshot 2025-03-06 at 3 24 20 PM

"@walletconnect/socket-transport/ws": "^7.5.10",
"@ethersproject/providers/ws": "^7.5.10",
"puppeteer-core/ws": "^8.17.1",
"react-native/ws": "^6.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like react-native/ws is in our dependency tree

Screenshot 2025-03-06 at 3 24 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants