Skip to content

chore: remove unnecessary peer dependencies #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

chore: remove unnecessary peer dependencies #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/storybook-react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
"@metamask/design-system-twrnc-preset": "workspace:^",
"@metamask/design-tokens": "workspace:^",
"@metamask/utils": "^11.8.0",
"@solana/addresses": "^2.0.0",
"bitcoin-address-validation": ">=2.0.0",
Comment on lines -20 to -21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed in #816 but dependencies weren't updated

"expo": "~49.0.23",
"expo-status-bar": "~1.6.0",
"expo-system-ui": "~2.4.0",
Expand Down
2 changes: 0 additions & 2 deletions apps/storybook-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"@metamask/design-tokens": "workspace:^",
"@metamask/utils": "^11.8.0",
"@playwright/test": "^1.52.0",
"@solana/addresses": "^2.0.0",
"@storybook/addon-a11y": "^9.0.17",
"@storybook/addon-docs": "^9.0.17",
"@storybook/addon-vitest": "^9.0.17",
Expand All @@ -31,7 +30,6 @@
"@vitest/coverage-v8": "^3.2.4",
"autoprefixer": "^10.0.0",
"axe-playwright": "^2.1.0",
"bitcoin-address-validation": ">=2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed in #816 but dependencies weren't updated

"playwright": "^1.52.0",
"postcss": "^8.4.47",
"prop-types": "^15.8.1",
Expand Down
4 changes: 0 additions & 4 deletions packages/design-system-react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"@metamask/design-system-twrnc-preset": "workspace:^",
"@metamask/design-tokens": "workspace:^",
"@metamask/utils": "^11.8.0",
"@solana/addresses": "^2.0.0",
"@storybook/react-native": "6.5",
"@testing-library/react-hooks": "^8.0.1",
"@testing-library/react-native": "^12.8.1",
Expand All @@ -73,7 +72,6 @@
"@types/react": "^18.2.0",
"@types/react-test-renderer": "^18",
"babel-jest": "^29.7.0",
"bitcoin-address-validation": ">=2.0.0",
"deepmerge": "^4.2.2",
"jest": "^29.7.0",
"metro-react-native-babel-preset": "^0.77.0",
Expand All @@ -92,8 +90,6 @@
"@metamask/design-system-twrnc-preset": "^0.2.0",
"@metamask/design-tokens": "^8.1.0",
"@metamask/utils": "^11.8.0",
"@solana/addresses": "^2.0.0",
"bitcoin-address-validation": ">=2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed in #816 but dependencies weren't updated

"react": ">=18.2.0",
"react-native": ">=0.72.0",
"react-native-gesture-handler": ">=1.10.3",
Expand Down
27 changes: 0 additions & 27 deletions packages/design-system-react-native/src/types/bitcoin-address-validation.d.ts
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed as we've removed bitcoin-address-validation

This file was deleted.

7 changes: 1 addition & 6 deletions packages/design-system-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"@metamask/auto-changelog": "^5.0.2",
"@metamask/design-system-tailwind-preset": "workspace:^",
"@metamask/utils": "^11.8.0",
"@solana/addresses": "^2.0.0",
"@storybook/react": "^9.0.17",
"@svgr/cli": "^8.1.0",
"@testing-library/jest-dom": "^6.6.3",
Expand All @@ -72,7 +71,6 @@
"@types/node": "^16.18.54",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"bitcoin-address-validation": ">=2.0.0",
"deepmerge": "^4.2.2",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
Expand All @@ -85,11 +83,8 @@
"@metamask/design-system-tailwind-preset": "^0.6.0",
"@metamask/design-tokens": "^8.1.0",
"@metamask/utils": "^11.8.0",
"@solana/addresses": "^2.0.0",
"bitcoin-address-validation": ">=2.0.0",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0",
"tailwindcss": "^3.0.0"
"react-dom": "^17.0.0 || ^18.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Tailwind CSS Missing in Peer Dependencies

The tailwindcss peer dependency was removed, but the package still relies on Tailwind CSS for styling via @metamask/design-system-tailwind-preset and tailwind-merge. This may lead to peer dependency warnings or runtime styling issues for consumers, as tailwindcss remains a critical dependency for this design system.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix an issue with the attributions https://consensys.slack.com/archives/C09CYHMHPMY/p1757939224436239?thread_ts=1757671235.871049&cid=C09CYHMHPMY

},
"engines": {
"node": "^18.18 || >=20"
Expand Down
27 changes: 0 additions & 27 deletions packages/design-system-react/src/types/bitcoin-address-validation.d.ts
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed as we've removed bitcoin-address-validation

This file was deleted.

3 changes: 0 additions & 3 deletions packages/design-system-react/src/types/make-props-optional.ts
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MakePropsOptional is not used anywhere and can be replaced by Partial

Screenshot 2025-09-15 at 4 12 41 PM

This file was deleted.

140 changes: 1 addition & 139 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3337,7 +3337,6 @@ __metadata:
"@metamask/design-system-twrnc-preset": "workspace:^"
"@metamask/design-tokens": "workspace:^"
"@metamask/utils": "npm:^11.8.0"
"@solana/addresses": "npm:^2.0.0"
"@storybook/react-native": "npm:6.5"
"@testing-library/react-hooks": "npm:^8.0.1"
"@testing-library/react-native": "npm:^12.8.1"
Expand All @@ -3349,7 +3348,6 @@ __metadata:
"@types/react": "npm:^18.2.0"
"@types/react-test-renderer": "npm:^18"
babel-jest: "npm:^29.7.0"
bitcoin-address-validation: "npm:>=2.0.0"
deepmerge: "npm:^4.2.2"
fast-text-encoding: "npm:^1.0.6"
jest: "npm:^29.7.0"
Expand All @@ -3369,8 +3367,6 @@ __metadata:
"@metamask/design-system-twrnc-preset": ^0.2.0
"@metamask/design-tokens": ^8.1.0
"@metamask/utils": ^11.8.0
"@solana/addresses": ^2.0.0
bitcoin-address-validation: ">=2.0.0"
react: ">=18.2.0"
react-native: ">=0.72.0"
react-native-gesture-handler: ">=1.10.3"
Expand All @@ -3390,7 +3386,6 @@ __metadata:
"@metamask/jazzicon": "npm:^2.0.0"
"@metamask/utils": "npm:^11.8.0"
"@radix-ui/react-slot": "npm:^1.1.0"
"@solana/addresses": "npm:^2.0.0"
"@storybook/react": "npm:^9.0.17"
"@svgr/cli": "npm:^8.1.0"
"@testing-library/jest-dom": "npm:^6.6.3"
Expand All @@ -3400,7 +3395,6 @@ __metadata:
"@types/node": "npm:^16.18.54"
"@types/react": "npm:^18.2.0"
"@types/react-dom": "npm:^18.2.0"
bitcoin-address-validation: "npm:>=2.0.0"
blo: "npm:^2.0.0"
deepmerge: "npm:^4.2.2"
jest: "npm:^29.7.0"
Expand All @@ -3414,11 +3408,8 @@ __metadata:
"@metamask/design-system-tailwind-preset": ^0.6.0
"@metamask/design-tokens": ^8.1.0
"@metamask/utils": ^11.8.0
"@solana/addresses": ^2.0.0
bitcoin-address-validation: ">=2.0.0"
react: ^17.0.0 || ^18.0.0
react-dom: ^17.0.0 || ^18.0.0
tailwindcss: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3645,7 +3636,6 @@ __metadata:
"@react-native-async-storage/async-storage": "npm:^2.0.0"
"@react-native-community/datetimepicker": "npm:^8.2.0"
"@react-native-community/slider": "npm:^4.5.5"
"@solana/addresses": "npm:^2.0.0"
"@storybook/addon-actions": "npm:6.5"
"@storybook/addon-controls": "npm:6.5"
"@storybook/addon-ondevice-actions": "npm:6.5"
Expand All @@ -3654,7 +3644,6 @@ __metadata:
"@types/react": "npm:^18.2.0"
"@types/react-dom": "npm:^18.2.0"
"@types/react-native-get-random-values": "npm:^1"
bitcoin-address-validation: "npm:>=2.0.0"
expo: "npm:~49.0.23"
expo-status-bar: "npm:~1.6.0"
expo-system-ui: "npm:~2.4.0"
Expand All @@ -3681,7 +3670,6 @@ __metadata:
"@metamask/design-tokens": "workspace:^"
"@metamask/utils": "npm:^11.8.0"
"@playwright/test": "npm:^1.52.0"
"@solana/addresses": "npm:^2.0.0"
"@storybook/addon-a11y": "npm:^9.0.17"
"@storybook/addon-docs": "npm:^9.0.17"
"@storybook/addon-vitest": "npm:^9.0.17"
Expand All @@ -3697,7 +3685,6 @@ __metadata:
"@vitest/coverage-v8": "npm:^3.2.4"
autoprefixer: "npm:^10.0.0"
axe-playwright: "npm:^2.1.0"
bitcoin-address-validation: "npm:>=2.0.0"
playwright: "npm:^1.52.0"
postcss: "npm:^8.4.47"
prop-types: "npm:^15.8.1"
Expand Down Expand Up @@ -4549,92 +4536,6 @@ __metadata:
languageName: node
linkType: hard

"@solana/addresses@npm:^2.0.0":
version: 2.1.1
resolution: "@solana/addresses@npm:2.1.1"
dependencies:
"@solana/assertions": "npm:2.1.1"
"@solana/codecs-core": "npm:2.1.1"
"@solana/codecs-strings": "npm:2.1.1"
"@solana/errors": "npm:2.1.1"
"@solana/nominal-types": "npm:2.1.1"
peerDependencies:
typescript: ">=5.3.3"
checksum: 10/0350aa5c96c9862701e5414ca14007fafe7b9c4dfd2623bc041ff7efe6a63afac37d9bf01f860c26ae0f252e5bca7af9059a20f944fe3dc273d0558f2da69d34
languageName: node
linkType: hard

"@solana/assertions@npm:2.1.1":
version: 2.1.1
resolution: "@solana/assertions@npm:2.1.1"
dependencies:
"@solana/errors": "npm:2.1.1"
peerDependencies:
typescript: ">=5.3.3"
checksum: 10/3424d6e5066b4abfa07a606e9ab95c4c856cf91d57bc812df2815fdd30ec84b8a85d611baa79a78021cfcc6501cac7d46a22364c7f33768f243750329e6459f6
languageName: node
linkType: hard

"@solana/codecs-core@npm:2.1.1":
version: 2.1.1
resolution: "@solana/codecs-core@npm:2.1.1"
dependencies:
"@solana/errors": "npm:2.1.1"
peerDependencies:
typescript: ">=5.3.3"
checksum: 10/b0c426b5028cdfc9a71d55d61ca1b9815c951cdf3557142512a89418fd5cde75b4e1214f548f0e4fd5b8d3431bd51cd5da0ddfeb1afc40742cbc041cc4a04412
languageName: node
linkType: hard

"@solana/codecs-numbers@npm:2.1.1":
version: 2.1.1
resolution: "@solana/codecs-numbers@npm:2.1.1"
dependencies:
"@solana/codecs-core": "npm:2.1.1"
"@solana/errors": "npm:2.1.1"
peerDependencies:
typescript: ">=5.3.3"
checksum: 10/eb28724fee926a5b2416527d452f1a5d73b4db776319f629662320452edd4e457f4b7cf4b022bc8a45de7cf9730f650698026b56e894c5cf21bf16682b7d35fe
languageName: node
linkType: hard

"@solana/codecs-strings@npm:2.1.1":
version: 2.1.1
resolution: "@solana/codecs-strings@npm:2.1.1"
dependencies:
"@solana/codecs-core": "npm:2.1.1"
"@solana/codecs-numbers": "npm:2.1.1"
"@solana/errors": "npm:2.1.1"
peerDependencies:
fastestsmallesttextencoderdecoder: ^1.0.22
typescript: ">=5.3.3"
checksum: 10/7ade3b9342f7adeb28263cced496c24228d81165da14ed4f35923a6452308bb836de154665340931614fc5e842e6d196d05afc59921beb151e56c952d93657ed
languageName: node
linkType: hard

"@solana/errors@npm:2.1.1":
version: 2.1.1
resolution: "@solana/errors@npm:2.1.1"
dependencies:
chalk: "npm:^5.4.1"
commander: "npm:^13.1.0"
peerDependencies:
typescript: ">=5.3.3"
bin:
errors: bin/cli.mjs
checksum: 10/afd9290e5e924c68dd98f5d6dd3490b28dc03d94b4063146f33eec83967686c5895d7560bc8b829ee781dfd9221ae732f2ac0cb41551f33d3baffb58efc5f645
languageName: node
linkType: hard

"@solana/nominal-types@npm:2.1.1":
version: 2.1.1
resolution: "@solana/nominal-types@npm:2.1.1"
peerDependencies:
typescript: ">=5.3.3"
checksum: 10/e114329abca077ae896bad26c82fd248fdd63034912021ccc17327bacfe7639e063c743c0becdba326e95fd4fd73e99f3e8b91e1a411e37b478ca72c5efae93b
languageName: node
linkType: hard

"@storybook/addon-a11y@npm:^9.0.17":
version: 9.0.17
resolution: "@storybook/addon-a11y@npm:9.0.17"
Expand Down Expand Up @@ -7638,13 +7539,6 @@ __metadata:
languageName: node
linkType: hard

"base58-js@npm:^3.0.2":
version: 3.0.2
resolution: "base58-js@npm:3.0.2"
checksum: 10/2a1e734889b39b26b5415d7ecea072ec22d91467db4558d43be25f6ffee8a195096dc947e9b7fe453b7bf2d0280ca1398c3ffc6c7b6b383329e8a95cec2e6c85
languageName: node
linkType: hard

"base64-js@npm:^1.0.2, base64-js@npm:^1.1.2, base64-js@npm:^1.2.3, base64-js@npm:^1.3.1, base64-js@npm:^1.5.1":
version: 1.5.1
resolution: "base64-js@npm:1.5.1"
Expand All @@ -7667,13 +7561,6 @@ __metadata:
languageName: node
linkType: hard

"bech32@npm:^2.0.0":
version: 2.0.0
resolution: "bech32@npm:2.0.0"
checksum: 10/fa15acb270b59aa496734a01f9155677b478987b773bf701f465858bf1606c6a970085babd43d71ce61895f1baa594cb41a2cd1394bd2c6698f03cc2d811300e
languageName: node
linkType: hard

"better-opn@npm:^3.0.2, better-opn@npm:~3.0.2":
version: 3.0.2
resolution: "better-opn@npm:3.0.2"
Expand Down Expand Up @@ -7732,17 +7619,6 @@ __metadata:
languageName: node
linkType: hard

"bitcoin-address-validation@npm:>=2.0.0":
version: 3.0.0
resolution: "bitcoin-address-validation@npm:3.0.0"
dependencies:
base58-js: "npm:^3.0.2"
bech32: "npm:^2.0.0"
sha256-uint8array: "npm:^0.10.3"
checksum: 10/3703f27501ea9c3bebad2c5a0448850a5c13f4d2df419ae72bfc458ff658283d29cc24e4cb34b99d5c6b5dec4bb58b3897456934213efd7b6f758bc87c81293b
languageName: node
linkType: hard

"bl@npm:^4.1.0":
version: 4.1.0
resolution: "bl@npm:4.1.0"
Expand Down Expand Up @@ -8346,7 +8222,7 @@ __metadata:
languageName: node
linkType: hard

"chalk@npm:^5.3.0, chalk@npm:^5.4.1":
"chalk@npm:^5.3.0":
version: 5.4.1
resolution: "chalk@npm:5.4.1"
checksum: 10/29df3ffcdf25656fed6e95962e2ef86d14dfe03cd50e7074b06bad9ffbbf6089adbb40f75c00744d843685c8d008adaf3aed31476780312553caf07fa86e5bc7
Expand Down Expand Up @@ -8782,13 +8658,6 @@ __metadata:
languageName: node
linkType: hard

"commander@npm:^13.1.0":
version: 13.1.0
resolution: "commander@npm:13.1.0"
checksum: 10/d3b4b79e6be8471ddadacbb8cd441fe82154d7da7393b50e76165a9e29ccdb74fa911a186437b9a211d0fc071db6051915c94fb8ef16d77511d898e9dbabc6af
languageName: node
linkType: hard

"commander@npm:^2.20.0":
version: 2.20.3
resolution: "commander@npm:2.20.3"
Expand Down Expand Up @@ -19203,13 +19072,6 @@ __metadata:
languageName: node
linkType: hard

"sha256-uint8array@npm:^0.10.3":
version: 0.10.7
resolution: "sha256-uint8array@npm:0.10.7"
checksum: 10/e427f9d2f9c521dea552f033d3f0c3bd641ab214d214dd41bde3c805edde393519cf982b3eee7d683b32e5f28fa23b2278d25935940e13fbe831b216a37832be
languageName: node
linkType: hard

"shallow-clone@npm:^3.0.0":
version: 3.0.1
resolution: "shallow-clone@npm:3.0.1"
Expand Down
Loading