Skip to content

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Sep 18, 2025

Description

Fixes peer dependency constraints for pre-1.0 packages in the monorepo. The previous implementation only used major version ranges (^0.0.0 for all pre-1.0 packages), which was too permissive and could allow incompatible older versions. This update ensures peer dependencies correctly reflect the most significant version digit for breaking changes, following semantic versioning best practices for pre-1.0 packages.

Same PR in core

Related issues

Fixes:

Manual testing steps

  1. Run yarn constraints to verify no constraint violations
  2. Check that the updated logic handles various version scenarios:
    • 0.4.1 → generates ^0.4.0 peer dependency range
    • 0.2.1 → generates ^0.2.0 peer dependency range
    • 8.1.1 → generates ^8.0.0 peer dependency range (unchanged)
    • 0.0.5 → generates ^0.0.5 peer dependency range
  3. Verify existing peer dependencies in package.json files remain valid
  4. Test that the constraint logic properly prevents version mismatches

Screenshots/Recordings

Not applicable - this is a build configuration improvement with no visual changes.

Before

Pre-1.0 packages generated overly permissive ^0.0.0 peer dependency ranges.

After

Pre-1.0 packages generate appropriate ranges: ^0.minor.0 for minor-based versions, ^0.0.patch for patch-only versions.

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall self-assigned this Sep 18, 2025
@georgewrmarshall georgewrmarshall marked this pull request as ready for review September 18, 2025 17:45
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner September 18, 2025 17:45
@georgewrmarshall georgewrmarshall requested review from Gudahtt and removed request for Gudahtt September 18, 2025 22:27
Copy link
Contributor

📖 Storybook Preview

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the peer dependency generation logic for pre-1.0 packages to follow semantic versioning best practices. Previously, all pre-1.0 packages used overly permissive ^0.0.0 ranges, which could allow incompatible versions. The fix ensures peer dependencies reflect the most significant version digit for breaking changes.

  • Implements proper version range calculation for pre-1.0 packages based on which version component is non-zero
  • Replaces hardcoded ^major.0.0 pattern with conditional logic for major, minor, and patch-level versions
  • Maintains backward compatibility while preventing version mismatches in monorepo dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@georgewrmarshall georgewrmarshall merged commit 430316f into main Sep 19, 2025
41 of 42 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/peer-deps-yarn-config branch September 19, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants