-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated mixins with text component in loading-swaps-quotes #25553
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Tagging @georgewrmarshall for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25553 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1350 1350
Lines 47865 47865
Branches 13199 13199
========================================
Hits 33355 33355
Misses 14510 14510 ☔ View full report in Codecov by Sentry. |
Builds ready [94259f1]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs
|
Description
This pull request replaces deprecated mixins with the Text component in the
loading-swaps-quotes
file. The changes include updating the SCSS and JS files to use the Text component and related enums, as well as deleting specific SCSS instances as instructed by the user.Devin Run Link: https://staging.itsdev.in/devin/edffa827e63141c8a3214c25ecf4a760
Related issues
Partially Fixes: #20496
Manual testing steps
LoadingSwapQuotes
is getting rendered properlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist