feat: Remove blockaid migration BannerAlert #25556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
force-pushed
the
pnf/remove-blockaid-banner-alert
branch
from
fb6dad3
to
ee52290
Compare
matthewwalsh0
approved these changes
Jun 27, 2024
| @@ -51,7 +51,6 @@ export default class PreferencesController { | |||
| eth_sign: false, | |||
| }, | |||
| useMultiAccountBalanceChecker: true, | |||
| hasDismissedOpenSeaToBlockaidBanner: false, | |||
There was a problem hiding this comment.
Just for audit sake, I agree that no migration is needed for this since it's a single boolean rather than a large array or object.
There was a problem hiding this comment.
good shout, thanks for pointing it out
vinistevam
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On #23743, we introduced a BannerAlert that warns the user if they migrated from OpenSea to Blockaid security alerts and they are on a network that doesn't support them.
Since enough time has passed, this PR removes that logic
Related issues
#23743
Manual testing steps
See instructions on #23743
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist