Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for GasTiming component #25557

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 27, 2024

Description

This pull request adds a Storybook story for the GasTiming component in the MetaMask extension. The reason for this change is to enable isolated testing and visualization of the GasTiming component within Storybook. The improvement/solution provided by this change is the ability to interact with and test the GasTiming component in isolation, ensuring it renders correctly and behaves as expected.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the GasTiming component in the Components/ folder.

Screenshots/Recordings

![gas-timing](https://gas-timing-app-prl8fbix.devinapps.com)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by Devin.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot changed the title chore: Create a story for gas-timing component chore: Create a story for GasTiming component Jun 27, 2024
@garrettbear garrettbear added team-design-system All issues relating to design system in Extension external-contributor labels Jun 27, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove screenshot file

.gitignore Outdated
Comment on lines 82 to 84
# Ignore untracked files for PR
app/images/gas-timing.png
ui/__mocks__/storeMock.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When gas-timing.png is removed these changes can also be removed

Suggested change
# Ignore untracked files for PR
app/images/gas-timing.png
ui/__mocks__/storeMock.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant