-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a story for GasTiming component #25557
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3d1d8e7
to
b8485e7
Compare
.storybook/images/gas-timing.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove screenshot file
.gitignore
Outdated
# Ignore untracked files for PR | ||
app/images/gas-timing.png | ||
ui/__mocks__/storeMock.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When gas-timing.png
is removed these changes can also be removed
# Ignore untracked files for PR | |
app/images/gas-timing.png | |
ui/__mocks__/storeMock.js |
fb96958
to
aba028f
Compare
Description
This pull request adds a Storybook story for the
GasTiming
component in the MetaMask extension. The reason for this change is to enable isolated testing and visualization of theGasTiming
component within Storybook. The improvement/solution provided by this change is the ability to interact with and test theGasTiming
component in isolation, ensuring it renders correctly and behaves as expected.Related issues
Manual testing steps
Screenshots/Recordings
![gas-timing](https://gas-timing-app-prl8fbix.devinapps.com)Pre-merge author checklist
Pre-merge reviewer checklist
This Devin run was requested by Devin.