fix: add eth_signTypedData and eth_signTypedData_v3 to methodsRequiringNetworkSwitch
#25562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
force-pushed
the
ad/add-signing-methods-to-methodsRequiringNetworkSwitch
branch
from
4e377b2
to
6f4e8e7
Compare
adonesky1
force-pushed
the
ad/add-signing-methods-to-methodsRequiringNetworkSwitch
branch
from
869d327
to
2295e01
Compare
jiexi
previously approved these changes
Jun 27, 2024
|
Works great! fixed.mov |
adonesky1
force-pushed
the
ad/add-signing-methods-to-methodsRequiringNetworkSwitch
branch
from
f19515b
to
7235b0e
Compare
adonesky1
added
the
release-12.0.0
digiwand
previously approved these changes
Jun 27, 2024
sleepytanya
previously approved these changes
Jun 27, 2024
adonesky1
dismissed stale reviews from sleepytanya, danjm, and digiwand
via
a7b7d07
sleepytanya
previously approved these changes
Jun 28, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/25585?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
digiwand
approved these changes
Jun 28, 2024
jiexi
approved these changes
Jun 28, 2024
Builds ready [d3f4b01]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
adonesky1
deleted the
ad/add-signing-methods-to-methodsRequiringNetworkSwitch
branch
](https://codespaces.new/MetaMask/metamask-extension/pull/25585?quickstart=1){kind=link}
metamaskbot
added
the
release-12.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Though signature requests like
personal_sign,eth_signTypedData,eth_signTypedData_v3andeth_signTypedData_v4do not depend on state of network connections, these confirmations do use nicknames/addressbook state which is dependent on globally selected network state for parsing signatures and injecting nicknaming where possible. The queueing system introduced with Amon Hen v1 (v12.0.0 release) introduces certain conditions in which these signature confirmations will be rendered on the wrong network. Though this doesn't actually result in faulty signatures, we should switch to the appropriate/expected network for the UX reasons described above. Addingeth_signTypedData_v3andeth_signTypedDatato themethodsRequiringNetworkSwitcharray will cause the network to switch to the selected network for the requesting origin before initializing the confirmation.Related issues
Fixes: #25528
See this slack thread: https://consensys.slack.com/archives/C06FXU326RL/p1719429561925649?thread_ts=1719415715.492249&cid=C06FXU326RL
Manual testing steps
See videos below 👇
Screenshots/Recordings
Before
Screen.Recording.2024-06-27.at.9.45.06.AM.mov
After
Screen.Recording.2024-06-27.at.9.37.17.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist