Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Nov 24, 2025

Description

Doubling timeout value when creating Snap-based BIP-44 accounts.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Updating timeout for BIP-44 account creations (from 3s to 6s)

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Increase Snap-based BIP-44 account creation timeout from 3s to 6s in multichain-account-service-init.ts.

Written by Cursor Bugbot for commit fddb9ad. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [fddb9ad]
UI Startup Metrics (1185 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1185993149210512271416
load101184313249610521197
domContentLoaded100583713109510491187
domInteractive27141252620106
firstPaint55390131940410041158
backgroundConnect2071922519210232
firstReactRender2919163163246
getState30166783344
initialActions104112
loadScripts804643111392843978
setupStore1072331116
numNetworkReqs1257821575
BrowserifyPower User HomeuiStartup18451596218314519592108
load98888014871319841365
domContentLoaded97487214791329651355
domInteractive40162014530186
firstPaint4649014923519081019
backgroundConnect21820125711223238
firstReactRender85421582194121
getState16612524025184215
initialActions103113
loadScripts77267312701317611139
setupStore20105292341
numNetworkReqs1096629545122191
WebpackStandard HomeuiStartup8307031121878631029
load65157186980704831
domContentLoaded64656886480700827
domInteractive28151182622107
firstPaint22979787161218653
backgroundConnect953551018
firstReactRender28197693241
getState261467113445
initialActions104112
loadScripts64456685578698825
setupStore1152641220
numNetworkReqs1257821574
WebpackPower User HomeuiStartup13991205184714415151641
load6605711042110658972
domContentLoaded6515661035110643967
domInteractive39172224231158
firstPaint24693965147238594
backgroundConnect1473351723
firstReactRender80421141587100
getState14812426618156176
initialActions102011
loadScripts6485641026108641958
setupStore22966153552
numNetworkReqs1516832058197300
FirefoxBrowserifyStandard HomeuiStartup12201073160211212711450
load102890712667810721192
domContentLoaded102790712667810721191
domInteractive61293174482138
firstPaint------
backgroundConnect3621113163875
firstReactRender22173652235
getState11513014920
initialActions102012
loadScripts100689112417510511141
setupStore12596141046
numNetworkReqs1157014752
BrowserifyPower User HomeuiStartup24882014299924627042927
load1156971167515511751592
domContentLoaded1155971167515411741592
domInteractive12532559115117440
firstPaint------
backgroundConnect1083176683121224
firstReactRender904316624101134
getState24764804194371713
initialActions2112227
loadScripts1123951161314911391507
setupStore1599771192177678
numNetworkReqs93622264579215
WebpackStandard HomeuiStartup14351264185912614841743
load1223105014889812871440
domContentLoaded1223105014889812871440
domInteractive60272494480165
firstPaint------
backgroundConnect4118120194488
firstReactRender27197992836
getState1164581221
initialActions103112
loadScripts1198103414599212581368
setupStore12485121029
numNetworkReqs1156716663
WebpackPower User HomeuiStartup26282200323622827773045
load13521133197015814561649
domContentLoaded13521133196915814561649
domInteractive11432483106112410
firstPaint------
backgroundConnect1052552281112253
firstReactRender84462252595121
getState27571897227451779
initialActions4062837
loadScripts13091113179614713501624
setupStore104774215391568
numNetworkReqs926321136128154
📊 Page Load Benchmark Results

Current Commit: fddb9ad | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±37ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.34s 1.08s 1.34s
domContentLoaded 723ms 37ms 700ms 995ms 761ms 995ms
firstPaint 78ms 13ms 56ms 184ms 88ms 184ms
firstContentfulPaint 78ms 13ms 56ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@ccharly ccharly marked this pull request as ready for review November 24, 2025 15:43
@ccharly
Copy link
Contributor Author

ccharly commented Dec 2, 2025

Actually, I found the real reason of those TimeoutErrors, see:

@ccharly ccharly closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants