feat: assign a UUID to all BaseProvider requests
#399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
changed the title
uuid to all BaseProvider requests
cryptodev-2s
changed the title
uuid to all BaseProvider requestsuuid to all BaseProvider requests
cryptodev-2s
changed the title
uuid to all BaseProvider requestsUUID to all BaseProvider requests
cryptodev-2s
changed the title
UUID to all BaseProvider requestsUUID to all BaseProvider requests
7 tasks
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@types/[email protected] |
mcmire
reviewed
Jan 22, 2025
| @@ -208,9 +209,11 @@ export abstract class BaseProvider extends SafeEventEmitter { | |||
| const payload = | |||
| params === undefined || params === null | |||
| ? { | |||
| id: uuidV4(), | |||
There was a problem hiding this comment.
Nit: Do we want to do this in _rpcRequest? I see that we already provide a default value for jsonrpc if it's not given so it seems like this check for id may belong there too.
There was a problem hiding this comment.
More importantly, can we add a test for this?
|
The PR was closed because this functionality should be managed by using an rpc middleware in the rpcMiddleware param available in providers, such as createIdRemapMiddleware, here: https://github.com/MetaMask/providers/blob/main/src/StreamProvider.ts#L58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assigns a UUID to all
BaseProviderrequests.