Skip to content

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 22, 2025

Enum were unintentionally exported as types, while client need the values.

@Gudahtt
Copy link
Member

Gudahtt commented Sep 22, 2025

Looks like it's failing because of the coverage threshold, due to additional lines added to index.ts

@mikesposito
Copy link
Member Author

@Gudahtt updated in 1490c1c

Gudahtt
Gudahtt previously approved these changes Sep 22, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt marked this pull request as ready for review September 22, 2025 19:23
@Gudahtt Gudahtt requested a review from a team as a code owner September 22, 2025 19:23
@Gudahtt Gudahtt dismissed their stale review September 22, 2025 19:24

Needs changelog entry

@mikesposito mikesposito requested a review from Gudahtt September 22, 2025 19:40
@mikesposito mikesposito enabled auto-merge (squash) September 22, 2025 19:41
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit a061231 into main Sep 22, 2025
18 checks passed
@mikesposito mikesposito deleted the mikesposito/fix/export-enums branch September 22, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants