Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New D3 Connect - name resolution snap #831

Merged
merged 9 commits into from
Oct 21, 2024
Merged

New D3 Connect - name resolution snap #831

merged 9 commits into from
Oct 21, 2024

Conversation

khanti42
Copy link
Collaborator

Closes: #698

@khanti42 khanti42 changed the title New D3 Connect [WIP] requires name resolution New D3 Connect [WIP] - name resolution snap Sep 27, 2024
@khanti42 khanti42 marked this pull request as ready for review October 3, 2024 12:38
@khanti42 khanti42 requested review from Montoya and a team as code owners October 3, 2024 12:38
@khanti42 khanti42 changed the title New D3 Connect [WIP] - name resolution snap New D3 Connect - name resolution snap Oct 3, 2024
@Montoya
Copy link
Contributor

Montoya commented Oct 14, 2024

I tested this Snap and did not get any results. Will be on hold until I can confirm it works.

@khanti42
Copy link
Collaborator Author

I updated the version with the fix from the team.

@khanti42
Copy link
Collaborator Author

Tested with 0.3.2 and I am able to get the name resolution for d3connect.vic like in the example video of the snap.

@FrederikBolding FrederikBolding merged commit 47f4873 into main Oct 21, 2024
15 checks passed
@FrederikBolding FrederikBolding deleted the newD3Connect branch October 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Snap] D3 Connect
4 participants