Change minimum time between cronjobs to 15 seconds #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // If the time until the next run is less than 15 seconds, we increase it | ||
| // to 15 seconds to avoid running jobs too frequently. | ||
| const ms = Math.max(next.getTime() - now.getTime(), 15_000); |
There was a problem hiding this comment.
What if the job is a job that runs every day but meant to start in 1 second?
There was a problem hiding this comment.
Good point, I need to rethink my approach 😅
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 507 507
Lines 11185 11185
Branches 1722 1722
=======================================
Hits 10619 10619
Misses 566 566 ☔ View full report in Codecov by Sentry. |
|
Question folks, why 15 seconds and not other lower values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the minimum time between cronjob executions to 15 seconds.
Related to: MetaMask/pm-security#392.