Skip to content

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 21, 2025

This removes the useCaip25Permission feature flag for the SnapController and enables the CAIP-25 behaviour by default.

Breaking changes

  • The SnapController no longer accepts the useCaip25Permission feature flag.

Note

Removes the useCaip25Permission feature flag and always grants endowment:caip25 when a Snap requests endowment:ethereum-provider, updating tests accordingly.

  • SnapController:
    • Remove FeatureFlags.useCaip25Permission.
    • Always add endowment:caip25 (with authorizedScopes caveat based on selected network) when endowment:ethereum-provider is requested in #getPermissionsToGrant.
  • Tests (SnapController.test.tsx):
    • Update install/update tests to expect CAIP-25 without feature flag.
    • Remove tests covering the disabled-flag case.
    • Adjust test setup/options to drop featureFlags.useCaip25Permission.

Written by Cursor Bugbot for commit bd0c978. This will update automatically on new commits. Configure here.

Copy link

codecov bot commented May 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (8571a4d) to head (bd0c978).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
- Coverage   98.27%   98.27%   -0.01%     
==========================================
  Files         417      417              
  Lines       11903    11901       -2     
  Branches     1845     1843       -2     
==========================================
- Hits        11698    11696       -2     
  Misses        205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgewrmarshall
Copy link

@metamaskbot publish-preview

FrederikBolding
FrederikBolding previously approved these changes Oct 1, 2025
@Mrtenz Mrtenz force-pushed the mrtenz/remove-caip-25-feature-flag branch from b7fe7d5 to bd0c978 Compare October 1, 2025 14:42
@Mrtenz Mrtenz marked this pull request as ready for review October 1, 2025 14:50
@Mrtenz Mrtenz requested a review from a team as a code owner October 1, 2025 14:50
@Mrtenz Mrtenz added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit f3e64c7 Oct 1, 2025
123 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-caip-25-feature-flag branch October 1, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants