Skip to content

chore: Bump @metamask/phishing-controller from 13.1.0 to 14.0.0 #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+41 −28
Open

chore: Bump @metamask/phishing-controller from 13.1.0 to 14.0.0 #3647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cdb288
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.0.0
dependabot[bot] Oct 2, 2025
0b91cac
[dependabot skip] Deduplicate yarn.lock
metamaskbot Oct 2, 2025
8146218
[dependabot skip] Update LavaMoat policies
metamaskbot Oct 2, 2025
7bfb954
[dependabot skip] Update example snaps
metamaskbot Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/packages/bip32/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "oi0SJgHkBHNpSf0XoEYYK+Z+TvUZhqecb21rUQlQy0Y=",
"shasum": "rCKMDRF7Y0gX6Gu5v3hYsllK5pUX+9GRg1ztmZiSLa8=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/bip44/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "LXKwLrypTOqL6Mdv8kqGnAIN7b7nqniSGExsLdm6/54=",
"shasum": "cusMbHuymWY6tZeP3s9VIKJ+yGNDskhQpIIJ6TweCwY=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/cronjobs/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "9MpZT/oQXNF3YMTA6kQEAfs0H9KymzHz8npynrk3usg=",
"shasum": "xJvLHlIO5PZl5aiqDVaD9KekniGYpJhFyOzKgkoVaOI=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/dialogs/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "veLIETfMO+3rmDoFa1sxg4355NahHoPcnAtzmjFH0RM=",
"shasum": "RT3QK/Bl2XW8O93eTzxm4kkhbWU2YLNgl0wIpQtA+Rw=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/ethereum-provider/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "cDnKVMC6SoAM8PT1dyMsEr7PfdF8NTDDnx1/iALwAHU=",
"shasum": "GTAcx5+xnYSrX0hPya1/fzzqRu9tKOZFlIM+m/GhRMY=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/ethers-js/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "9vYRKGi0UPGsuJqftpZ088N09useMhGn/jXEX9iPgZs=",
"shasum": "DxWxRAbWHwMP0A2cP69rtJnLG46DGVF23jVS/eZS/SA=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/get-entropy/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "MNSzZnFFBVH8HxYNy/mrrdwVgOTmPgM98ybPolHbpIw=",
"shasum": "WyWni7NEyMn/x9BZ9gpBG63rXNE+GhW1EmbKWir6Jn8=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/images/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "NtQ8Rk/qn41nHWgCsKqTqaYMMy8CoH8VRuhSbGuGq1s=",
"shasum": "FYjeWJZedR0CsGEYnHzfoFQDpmGZ6De/OS1Y2iQ1smc=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/interactive-ui/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "Et0r8P+ORsedVAqQ9iF02gHUBC0zZjWg/xptu4v/DlU=",
"shasum": "Ov0Ar65MX7lo2uYyp3Ib4ewVnK/HenJye0xb7uTC9E8=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/invoke-snap/packages/consumer-signer/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "C42+OsuPDhTmKpn2rMU1pHnVhIPja148c+YOGiBdBfs=",
"shasum": "dyTu7Uv4y/ENkS/Jnxqk9VMw7DtWI+RdF0JgV3H0trw=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/invoke-snap/packages/core-signer/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "dQa6M6vJM/qGyEtp0vZwXX3y+u2g7dfC9aMdql12m6w=",
"shasum": "o76aRih2nVsLM9K64BaOVLmjXNW77O816EWBH2YpAqs=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/send-flow/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "Jt6ffHQCRr/04n0/AioV2kZ9Mgn5ssqzbc9EKQ9a0Ck=",
"shasum": "yEqB3AAMpEz6knhYbegfL699DkfGcq+akyyPmSjILSg=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/signature-insights/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "KOnko171BdSfiZkvIc+b/YsX7xpb6tuMI/WDji3Q/7w=",
"shasum": "bbmlfPgCWVnA9fva9G+xUEYFJmLq84syVoFAGBDemaU=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/transaction-insights/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "sJ0/rptqCx0259FqNAJQl14JQCUMEqwJkgeI1u2y524=",
"shasum": "+XI+76eOneF1G6rf9+2gcWCdiN2jejkh7v/LFh7CQxY=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/snaps-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"@metamask/key-tree": "^10.1.1",
"@metamask/object-multiplex": "^2.1.0",
"@metamask/permission-controller": "^11.0.6",
"@metamask/phishing-controller": "^13.1.0",
"@metamask/phishing-controller": "^14.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Phishing Controller Update Requires Transaction Controller

The update to @metamask/[email protected] introduces a new peer dependency on @metamask/transaction-controller@^60.4.0. This package doesn't declare that peer dependency, which may lead to unmet peer dependency warnings or runtime errors if the phishing controller tries to use transaction controller features.

Additional Locations (1)

Fix in Cursor Fix in Web

"@metamask/post-message-stream": "^10.0.0",
"@metamask/rpc-errors": "^7.0.3",
"@metamask/snaps-registry": "^3.2.3",
Expand Down
1 change: 1 addition & 0 deletions packages/snaps-execution-environments/lavamoat/webpack/iframe/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
},
"@metamask/utils>@noble/hashes": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/snaps-execution-environments/lavamoat/webpack/node-process/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
},
"@metamask/utils>@noble/hashes": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/snaps-execution-environments/lavamoat/webpack/node-thread/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
},
"@metamask/utils>@noble/hashes": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/snaps-execution-environments/lavamoat/webpack/webview/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
},
"@metamask/utils>@noble/hashes": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/snaps-simulation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@metamask/json-rpc-middleware-stream": "^8.0.7",
"@metamask/key-tree": "^10.1.1",
"@metamask/permission-controller": "^11.0.6",
"@metamask/phishing-controller": "^13.1.0",
"@metamask/phishing-controller": "^14.0.0",
"@metamask/snaps-controllers": "workspace:^",
"@metamask/snaps-execution-environments": "workspace:^",
"@metamask/snaps-rpc-methods": "workspace:^",
Expand Down
33 changes: 21 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2884,7 +2884,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/base-controller@npm:^8.0.0, @metamask/base-controller@npm:^8.0.1, @metamask/base-controller@npm:^8.4.0":
"@metamask/base-controller@npm:^8.0.0, @metamask/base-controller@npm:^8.4.0":
version: 8.4.0
resolution: "@metamask/base-controller@npm:8.4.0"
dependencies:
Expand Down Expand Up @@ -3012,7 +3012,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/controller-utils@npm:^11.11.0, @metamask/controller-utils@npm:^11.5.0":
"@metamask/controller-utils@npm:^11.14.0, @metamask/controller-utils@npm:^11.5.0":
version: 11.14.0
resolution: "@metamask/controller-utils@npm:11.14.0"
dependencies:
Expand Down Expand Up @@ -3924,18 +3924,20 @@ __metadata:
languageName: node
linkType: hard

"@metamask/phishing-controller@npm:^13.1.0":
version: 13.1.0
resolution: "@metamask/phishing-controller@npm:13.1.0"
"@metamask/phishing-controller@npm:^14.0.0":
version: 14.0.0
resolution: "@metamask/phishing-controller@npm:14.0.0"
dependencies:
"@metamask/base-controller": "npm:^8.0.1"
"@metamask/controller-utils": "npm:^11.11.0"
"@noble/hashes": "npm:^1.4.0"
"@metamask/base-controller": "npm:^8.4.0"
"@metamask/controller-utils": "npm:^11.14.0"
"@noble/hashes": "npm:^1.8.0"
"@types/punycode": "npm:^2.1.0"
ethereum-cryptography: "npm:^2.1.2"
fastest-levenshtein: "npm:^1.0.16"
punycode: "npm:^2.1.1"
checksum: 10/c62f71291736dfd635cc69b2d422687d8d610591a5e1cd9a6b4806cdc19221a72fe7699c0cabe0a2a108b49c3cc4dcb88a5b283fba374fe13e54d5813fb77902
peerDependencies:
"@metamask/transaction-controller": ^60.4.0
checksum: 10/d6463142ceafd7a22812427c46387cc0c6b1c2dcc83a653e28a4d8a88e2f880438fead45d04a62cb27032f7741180576d3361adeef0a51a3b70e1e5396e8cfeb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Phishing Controller Upgrade Causes Missing Dependency

The @metamask/phishing-controller v14.0.0 upgrade introduced a new peer dependency on @metamask/transaction-controller ^60.4.0. This dependency isn't declared in @metamask/snaps-controllers or @metamask/snaps-simulation, which could cause runtime errors when the phishing controller tries to access transaction controller features.

Additional Locations (2)

Fix in Cursor Fix in Web

languageName: node
linkType: hard

Expand Down Expand Up @@ -4252,7 +4254,7 @@ __metadata:
"@metamask/key-tree": "npm:^10.1.1"
"@metamask/object-multiplex": "npm:^2.1.0"
"@metamask/permission-controller": "npm:^11.0.6"
"@metamask/phishing-controller": "npm:^13.1.0"
"@metamask/phishing-controller": "npm:^14.0.0"
"@metamask/post-message-stream": "npm:^10.0.0"
"@metamask/rpc-errors": "npm:^7.0.3"
"@metamask/snaps-registry": "npm:^3.2.3"
Expand Down Expand Up @@ -4544,7 +4546,7 @@ __metadata:
"@metamask/json-rpc-middleware-stream": "npm:^8.0.7"
"@metamask/key-tree": "npm:^10.1.1"
"@metamask/permission-controller": "npm:^11.0.6"
"@metamask/phishing-controller": "npm:^13.1.0"
"@metamask/phishing-controller": "npm:^14.0.0"
"@metamask/snaps-controllers": "workspace:^"
"@metamask/snaps-execution-environments": "workspace:^"
"@metamask/snaps-rpc-methods": "workspace:^"
Expand Down Expand Up @@ -4920,13 +4922,20 @@ __metadata:
languageName: node
linkType: hard

"@noble/hashes@npm:1.7.1, @noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.4.0, @noble/hashes@npm:^1.7.1":
"@noble/hashes@npm:1.7.1":
version: 1.7.1
resolution: "@noble/hashes@npm:1.7.1"
checksum: 10/ca3120da0c3e7881d6a481e9667465cc9ebbee1329124fb0de442e56d63fef9870f8cc96f264ebdb18096e0e36cebc0e6e979a872d545deb0a6fed9353f17e05
languageName: node
linkType: hard

"@noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.7.1, @noble/hashes@npm:^1.8.0":
version: 1.8.0
resolution: "@noble/hashes@npm:1.8.0"
checksum: 10/474b7f56bc6fb2d5b3a42132561e221b0ea4f91e590f4655312ca13667840896b34195e2b53b7f097ec080a1fdd3b58d902c2a8d0fbdf51d2e238b53808a177e
languageName: node
linkType: hard

"@noble/secp256k1@npm:^1.7.1":
version: 1.7.1
resolution: "@noble/secp256k1@npm:1.7.1"
Expand Down
Loading