Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add scaling of HPA data in the readme #24

Merged
merged 6 commits into from
Nov 15, 2021

Conversation

nanjiangshu
Copy link
Contributor

@nanjiangshu nanjiangshu commented Nov 11, 2021

Related issue(s) and PR(s)
This PR closes https://github.com/MetabolicAtlas/private-issues/issues/140.

Type of change

  • README

List of changes made

Added the description of how HPA data is scaled.

Checklist

  • My code follows the NBIS style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

@inghylt inghylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Does it makes sense to add (some) this information to https://metabolicatlas.org/documentation#Data-overlay as well?

Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @nanjiangshu.

@nanjiangshu
Copy link
Contributor Author

Nice work! Does it makes sense to add (some) this information to https://metabolicatlas.org/documentation#Data-overlay as well?

Good point @inghylt, but it's too tiny as a separate issue. I will add a comment to the existing issue https://app.zenhub.com/workspaces/metatlas-sprint-607745622d49260019ce115a/issues/metabolicatlas/metabolicatlas/738.

Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I left a comment regarding formatting, otherwise I think it looks good 👍

Copy link
Contributor

@e0 e0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change @nanjiangshu! I love the data analysis work you did and I think it's really helpful to include these charts here.

@nanjiangshu nanjiangshu merged commit d196aac into main Nov 15, 2021
@nanjiangshu nanjiangshu deleted the docs/readme-scaling-HPA branch November 15, 2021 14:12
@mihai-sysbio mihai-sysbio mentioned this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants