-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add scaling of HPA data in the readme #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Does it makes sense to add (some) this information to https://metabolicatlas.org/documentation#Data-overlay as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @nanjiangshu.
Good point @inghylt, but it's too tiny as a separate issue. I will add a comment to the existing issue https://app.zenhub.com/workspaces/metatlas-sprint-607745622d49260019ce115a/issues/metabolicatlas/metabolicatlas/738. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I left a comment regarding formatting, otherwise I think it looks good 👍
Co-authored-by: MalinAhlberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change @nanjiangshu! I love the data analysis work you did and I think it's really helpful to include these charts here.
Related issue(s) and PR(s)
This PR closes https://github.com/MetabolicAtlas/private-issues/issues/140.
Type of change
List of changes made
Added the description of how HPA data is scaled.
Checklist