-
Notifications
You must be signed in to change notification settings - Fork 24
Bot Human Links #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot Human Links #3953
Conversation
…feat/3938-bot-human-links
# Conflicts: # users/views.py
# Conflicts: # front_end/messages/cs.json # front_end/messages/en.json # front_end/messages/es.json # front_end/messages/pt.json # front_end/messages/zh-TW.json # front_end/messages/zh.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Nothing major & I'm happy with the User model update.
I only skimmed the front end, btw. So it would be good for a front end eng to also review
elisescu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
front_end/src/app/(main)/accounts/settings/bots/components/bot_controls.tsx
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/bots_disclaimer.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/create_button.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/create_button.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/create_button.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/create_button.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/update_button.tsx
Outdated
Show resolved
Hide resolved
front_end/src/app/(main)/accounts/settings/bots/components/update_button.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # users/serializers.py
Other fixes of minor but nasty bugs:
InputContainercomponent which affects a lot of forms: now we don't render input value in font-bold mode. E.g: