Add support for using PH on the NextJS server side #3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncarazon
requested changes
Dec 19, 2025
Comment on lines
+37
to
+40
| const distinctId = cookieValue | ||
| ? JSON.parse(cookieValue).distinct_id | ||
| : "anonymous"; | ||
|
|
Contributor
There was a problem hiding this comment.
I believe this can crash a function in JSON.parse if the cookie value is malformed and it won't be caught then
| const cookieValue = cookieStore.get(cookieName)?.value; | ||
| const distinctId = cookieValue | ||
| ? JSON.parse(cookieValue).distinct_id | ||
| : "anonymous"; |
Contributor
There was a problem hiding this comment.
I believe that anonymous is not the best fallback here, as then If there’s no cookie, every user becomes "anonymous" and will all share the same flag evaluation. Maybe it's better to go with a user's id or sth similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using PH on the server side, following https://posthog.com/tutorials/nextjs-analytics