Skip to content

Conversation

@Stagno
Copy link
Contributor

@Stagno Stagno commented Mar 17, 2020

Technical Description

Rewrites the ICON laplacian stencil in SIR (with dawn4py) and adds it to dawn4py tests.

Resolves / Enhances

resolves #692

Testing

Coupling with driver code: dawn-ico/AtlasUtilities#1
To verify that output didn't change:

  • build repo (follow instructions on root README)
  • python3 convergence_plot.py ./atlasIconLaplaceDriver
  • python3 convergence_plot.py ./mylibIconLaplaceDriver
  • repeat previous for master (using a different build folder)
  • diff *.txt files with same name

@Stagno Stagno marked this pull request as ready for review March 17, 2020 16:40
@Stagno
Copy link
Contributor Author

Stagno commented Mar 17, 2020

launch jenkins

1 similar comment
@Stagno
Copy link
Contributor Author

Stagno commented Mar 18, 2020

launch jenkins

@Stagno
Copy link
Contributor Author

Stagno commented Mar 18, 2020

launch jenkins

Copy link
Contributor

@mroethlin mroethlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@Stagno Stagno merged commit 76fc293 into MeteoSwiss-APN:master Mar 19, 2020
@Stagno Stagno deleted the ICON_stencil_from_SIR branch October 26, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICON stencil in SIR

2 participants