Skip to content

Support PUPPETEER_WAIT_TIMEOUT envrionment variable #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support PUPPETEER_WAIT_TIMEOUT envrionment variable #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e9f2f
Support PUPPETEER_WAIT_TIMEOUT envrionment variable
imajus Sep 19, 2024
2619242
Document PUPPETEER_WAIT_TIMEOUT environment variable
imajus Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ $ npm i --save-dev puppeteer@^19.11.1
$ TEST_BROWSER_DRIVER=puppeteer meteor test --once --driver-package <your package name>
```

Use `PUPPETEER_WAIT_TIMEOUT` env to set wait timeout in milliseconds after which the driver will forcefully stop running the tests (default is 30 minutes).

### Playwright

`playwright@^1.33.0` is the latest version with Node 14 compatibility (Meteor 2.x is set to use Node.js version 14.x by default).
Expand Down
16 changes: 14 additions & 2 deletions browser/puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
*/
const util = require('util');

// 30 minutes by default
const WAIT_TIMEOUT = process.env.PUPPETEER_WAIT_TIMEOUT
? Number.parseInt(process.env.PUPPETEER_WAIT_TIMEOUT, 10)
: 30 * 60 * 1000;

if (Number.isNaN(WAIT_TIMEOUT)) {
throw new Error(`Invalid PUPPETEER_WAIT_TIMEOUT value: ${process.env.PUPPETEER_WAIT_TIMEOUT}`);
}

export default function startPuppeteer({
stdout,
stderr,
Expand Down Expand Up @@ -63,7 +72,7 @@ export default function startPuppeteer({

await page.goto(process.env.ROOT_URL);

await page.waitForFunction(() => window.testsDone, { timeout: 0 });
await page.waitForFunction(() => window.testsDone, { timeout: WAIT_TIMEOUT });
const testFailures = await page.evaluate('window.testFailures');

await consolePromise;
Expand All @@ -73,5 +82,8 @@ export default function startPuppeteer({
done(testFailures);
}

runTests();
runTests().catch(err => {
stderr(err);
done();
});
}