Make chest swap close inventory because anticheats #4245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paddyk45
reviewed
Dec 2, 2023
| // Notchian clients send a Close Window packet with Window ID 0 to close their inventory even though there is never an Open Screen packet for the inventory. | ||
| var n = mc.getNetworkHandler(); | ||
| if (n != null) { | ||
| n.sendPacket(new CloseHandledScreenC2SPacket(0)); |
There was a problem hiding this comment.
Why are you checking if the network handler is null, it never will be null here
There was a problem hiding this comment.
tbqh idunno, I will go remove it
maxsupermanhd
force-pushed
the
master
branch
from
36599ff to
4796623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
On some servers anticheat does not allow attacking entities if you moved inventory without closing inventory first.
How Has This Been Tested?
On latest meteor dev and then with build from unstaged changes, seems like with option enabled anticheat does not block attacks anymore.
Tested on constantiam.
Checklist: