Image HUD element. #5756
Image HUD element. #5756
Conversation
… an URL/filepath and render it in game.
| private static final Identifier LOADING_TEXTURE = Identifier.of(MOD_ID,"textures/icons/gui/loading_image.png"); | ||
| private static final Color TRANSPARENT = new Color(255, 255, 255, 255); | ||
| private Identifier texture; | ||
| private final ExecutorService worker = Executors.newSingleThreadExecutor(); |
There was a problem hiding this comment.
Can be Util.getIoWorkerExecutor() or even virtual thread
| private void composeImage(String path) { | ||
| // Cancel the future immediately to recreate another texture for the user. | ||
| if (currentImageDataFuture != null && !currentImageDataFuture.isDone()) { | ||
| currentImageDataFuture.cancel(true); |
There was a problem hiding this comment.
I think we should debounce the modification rather than canceling?
There was a problem hiding this comment.
Do you suggest a custom delay, or for the original image to finish loading?
There was a problem hiding this comment.
For example, wait the original value stopped to change for 5 seconds, then we start to load.
|
|
||
| currentImageDataFuture = CompletableFuture.supplyAsync(() -> { | ||
| try { | ||
| InputStream imageFile = path.startsWith("http") ? new URL(path).openStream() : new FileInputStream(parsed); |
| } | ||
| } catch (Exception e) { | ||
| LOG.debug("Failed to load image", e); | ||
| texture = null; |
There was a problem hiding this comment.
Here it still accesses field texture on worker thread. Might move to exceptionallyAsync(..., mc)
| public int canvasHeight; | ||
| public int framesPerColumn; | ||
| int totalFrames; | ||
| public List<Integer> delays; |
There was a problem hiding this comment.
Performance, but it might not be important here.
|
I updated this PR with the changes you wanted. Lmk if I need to tweak anything else. @MukjepScarlet |
2 participants
Type of change
New Image element in HUD.
Description
You can select a new element to be rendered in your HUD: Image. It can load images from a filepath / URL and draw them in game. It also has support for GIFs.
Related issues
None
How Has This Been Tested?
Checklist: