Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getBins method #119

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Conversation

shadeglare
Copy link
Contributor

This patch overhauls the getBins method:

  • works for any amount of bin arrays
  • returns empty bins when no underlying bin array found

Copy link
Contributor

@00xSam 00xSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, but will need abit to amendment 🙏

ts-client/src/dlmm/index.ts Show resolved Hide resolved
@00xSam
Copy link
Contributor

00xSam commented Dec 9, 2024

LGTM, can u help rebase to latest main?

@codewithgun can u take a look as well?

@shadeglare
Copy link
Contributor Author

LGTM, can u help rebase to latest main?

@codewithgun can u take a look as well?

I merged the main branch into my pull request. Hope it won't get dated.

@00xSam
Copy link
Contributor

00xSam commented Dec 17, 2024

LGTM, can u help rebase to latest main?
@codewithgun can u take a look as well?

I merged the main branch into my pull request. Hope it won't get dated.

Hey @shadeglare , can rebase again. @codewithgun will review after rebase. Btw, what's the reason you're using generator?

ts-client/src/dlmm/types/index.ts Outdated Show resolved Hide resolved
ts-client/src/dlmm/types/index.ts Outdated Show resolved Hide resolved
@shadeglare
Copy link
Contributor Author

LGTM, can u help rebase to latest main?
@codewithgun can u take a look as well?

I merged the main branch into my pull request. Hope it won't get dated.

Hey @shadeglare , can rebase again. @codewithgun will review after rebase. Btw, what's the reason you're using generator?

It's for concise and less memory footprint. Filling bin array gaps is much easier with a generator and doesn't require array merging and index calculations.

@00xSam 00xSam merged commit 3424874 into MeteoraAg:main Dec 17, 2024
8 checks passed
@00xSam
Copy link
Contributor

00xSam commented Dec 17, 2024

@shadeglare published a new version, thanks for your contribution and patient 🙏

@meteora-ag/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants