-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor getBins method #119
Conversation
…/refactor_get_bins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, but will need abit to amendment 🙏
LGTM, can u help rebase to latest main? @codewithgun can u take a look as well? |
…x/refactor_get_bins
I merged the main branch into my pull request. Hope it won't get dated. |
Hey @shadeglare , can rebase again. @codewithgun will review after rebase. Btw, what's the reason you're using generator? |
It's for concise and less memory footprint. Filling bin array gaps is much easier with a generator and doesn't require array merging and index calculations. |
@shadeglare published a new version, thanks for your contribution and patient 🙏
|
This patch overhauls the
getBins
method: